Re: [PATCH net-next v6 4/5] virtio-net: add spin lock for ctrl cmd access

2023-12-06 Thread Jason Wang
On Thu, Dec 7, 2023 at 12:47 PM Heng Qi wrote: > > > > 在 2023/12/7 下午12:19, Jason Wang 写道: > > On Wed, Dec 6, 2023 at 9:03 PM Heng Qi wrote: > >> > >> > >> 在 2023/12/6 下午8:27, Paolo Abeni 写道: > >>> On Tue, 2023-12-05 at 19:05 +0800, Heng Qi wrote: > 在 2023/12/5 下午4:35, Jason Wang 写道: > >

Re: [PATCH net-next v6 4/5] virtio-net: add spin lock for ctrl cmd access

2023-12-06 Thread Heng Qi
在 2023/12/7 下午12:19, Jason Wang 写道: On Wed, Dec 6, 2023 at 9:03 PM Heng Qi wrote: 在 2023/12/6 下午8:27, Paolo Abeni 写道: On Tue, 2023-12-05 at 19:05 +0800, Heng Qi wrote: 在 2023/12/5 下午4:35, Jason Wang 写道: On Tue, Dec 5, 2023 at 4:02 PM Heng Qi wrote: Currently access to ctrl cmd is glob

Re: [PATCH net-next v6 4/5] virtio-net: add spin lock for ctrl cmd access

2023-12-06 Thread Jason Wang
On Wed, Dec 6, 2023 at 9:03 PM Heng Qi wrote: > > > > 在 2023/12/6 下午8:27, Paolo Abeni 写道: > > On Tue, 2023-12-05 at 19:05 +0800, Heng Qi wrote: > >> 在 2023/12/5 下午4:35, Jason Wang 写道: > >>> On Tue, Dec 5, 2023 at 4:02 PM Heng Qi wrote: > Currently access to ctrl cmd is globally protected via

Re: [PATCH net-next v6 4/5] virtio-net: add spin lock for ctrl cmd access

2023-12-06 Thread Heng Qi
在 2023/12/6 下午8:27, Paolo Abeni 写道: On Tue, 2023-12-05 at 19:05 +0800, Heng Qi wrote: 在 2023/12/5 下午4:35, Jason Wang 写道: On Tue, Dec 5, 2023 at 4:02 PM Heng Qi wrote: Currently access to ctrl cmd is globally protected via rtnl_lock and works fine. But if dim work's access to ctrl cmd also

Re: [PATCH net-next v6 4/5] virtio-net: add spin lock for ctrl cmd access

2023-12-06 Thread Paolo Abeni
On Tue, 2023-12-05 at 19:05 +0800, Heng Qi wrote: > > 在 2023/12/5 下午4:35, Jason Wang 写道: > > On Tue, Dec 5, 2023 at 4:02 PM Heng Qi wrote: > > > Currently access to ctrl cmd is globally protected via rtnl_lock and works > > > fine. But if dim work's access to ctrl cmd also holds rtnl_lock, deadlo

Re: [PATCH net-next v6 4/5] virtio-net: add spin lock for ctrl cmd access

2023-12-06 Thread Jason Wang
On Tue, Dec 5, 2023 at 7:06 PM Heng Qi wrote: > > > > 在 2023/12/5 下午4:35, Jason Wang 写道: > > On Tue, Dec 5, 2023 at 4:02 PM Heng Qi wrote: > >> Currently access to ctrl cmd is globally protected via rtnl_lock and works > >> fine. But if dim work's access to ctrl cmd also holds rtnl_lock, deadlock

Re: [PATCH net-next v6 4/5] virtio-net: add spin lock for ctrl cmd access

2023-12-05 Thread Heng Qi
在 2023/12/5 下午4:35, Jason Wang 写道: On Tue, Dec 5, 2023 at 4:02 PM Heng Qi wrote: Currently access to ctrl cmd is globally protected via rtnl_lock and works fine. But if dim work's access to ctrl cmd also holds rtnl_lock, deadlock may occur due to cancel_work_sync for dim work. Can you expla

Re: [PATCH net-next v6 4/5] virtio-net: add spin lock for ctrl cmd access

2023-12-05 Thread Jason Wang
On Tue, Dec 5, 2023 at 4:02 PM Heng Qi wrote: > > Currently access to ctrl cmd is globally protected via rtnl_lock and works > fine. But if dim work's access to ctrl cmd also holds rtnl_lock, deadlock > may occur due to cancel_work_sync for dim work. Can you explain why? > Therefore, treating >