Re: [PATCH net-next v5 4/5] netlink: pass extended ACK struct to parsing functions

2017-04-12 Thread Jiri Pirko
Wed, Apr 12, 2017 at 04:02:27PM CEST, kv...@codeaurora.org wrote: >Jiri Pirko writes: > >> Wed, Apr 12, 2017 at 02:34:07PM CEST, johan...@sipsolutions.net wrote: >>>From: Johannes Berg >>> >>>Pass the new extended ACK reporting struct to all of the >> >> Johannes, I wonder, is there a reason you

Re: [PATCH net-next v5 4/5] netlink: pass extended ACK struct to parsing functions

2017-04-12 Thread Kalle Valo
Jiri Pirko writes: > Wed, Apr 12, 2017 at 02:34:07PM CEST, johan...@sipsolutions.net wrote: >>From: Johannes Berg >> >>Pass the new extended ACK reporting struct to all of the > > Johannes, I wonder, is there a reason you ignore my comments about > narrow descriptions? Why don't you use the whol

Re: [PATCH net-next v5 4/5] netlink: pass extended ACK struct to parsing functions

2017-04-12 Thread Jiri Pirko
Wed, Apr 12, 2017 at 02:34:07PM CEST, johan...@sipsolutions.net wrote: >From: Johannes Berg > >Pass the new extended ACK reporting struct to all of the >generic netlink parsing functions. For now, pass NULL in >almost all callers (except for some in the core.) > >Signed-off-by: Johannes Berg >---

Re: [PATCH net-next v5 4/5] netlink: pass extended ACK struct to parsing functions

2017-04-12 Thread Jiri Pirko
Wed, Apr 12, 2017 at 03:20:36PM CEST, johan...@sipsolutions.net wrote: >On Wed, 2017-04-12 at 15:17 +0200, Jiri Pirko wrote: >> Wed, Apr 12, 2017 at 02:34:07PM CEST, johan...@sipsolutions.net >> wrote: >> > From: Johannes Berg >> > >> > Pass the new extended ACK reporting struct to all of the >>

Re: [PATCH net-next v5 4/5] netlink: pass extended ACK struct to parsing functions

2017-04-12 Thread Johannes Berg
On Wed, 2017-04-12 at 15:17 +0200, Jiri Pirko wrote: > Wed, Apr 12, 2017 at 02:34:07PM CEST, johan...@sipsolutions.net > wrote: > > From: Johannes Berg > > > > Pass the new extended ACK reporting struct to all of the > > Johannes, I wonder, is there a reason you ignore my comments about > narrow

Re: [PATCH net-next v5 4/5] netlink: pass extended ACK struct to parsing functions

2017-04-12 Thread Jiri Pirko
Wed, Apr 12, 2017 at 02:34:07PM CEST, johan...@sipsolutions.net wrote: >From: Johannes Berg > >Pass the new extended ACK reporting struct to all of the Johannes, I wonder, is there a reason you ignore my comments about narrow descriptions? Why don't you use the whole line? >generic netlink pars