Re: [PATCH net-next v5 2/3] net: implement threaded-able napi poll loop support

2020-12-15 Thread Jakub Kicinski
On Tue, 15 Dec 2020 18:15:06 -0800 Wei Wang wrote: > On Tue, Dec 15, 2020 at 5:53 PM Jakub Kicinski wrote: > > On Tue, 15 Dec 2020 17:25:14 -0800 Wei Wang wrote: > > > +void napi_enable(struct napi_struct *n) > > > +{ > > > + bool locked = rtnl_is_locked(); > > > > Maybe you'll prove me wr

Re: [PATCH net-next v5 2/3] net: implement threaded-able napi poll loop support

2020-12-15 Thread Jakub Kicinski
On Tue, 15 Dec 2020 17:25:14 -0800 Wei Wang wrote: > +void napi_enable(struct napi_struct *n) > +{ > + bool locked = rtnl_is_locked(); Maybe you'll prove me wrong but I think this is never a correct construct. > + BUG_ON(!test_bit(NAPI_STATE_SCHED, &n->state)); > + smp_mb__before_atom