Re: [PATCH net-next v3 3/7] vxlan: simplify exception handling

2016-11-15 Thread Pravin Shelar
On Tue, Nov 15, 2016 at 9:04 AM, Jiri Benc wrote: > On Tue, 15 Nov 2016 08:40:58 -0800, Pravin Shelar wrote: >> On Tue, Nov 15, 2016 at 6:30 AM, Jiri Benc wrote: >> > It would be a bit cleaner to do this assignment just after rt is >> > assigned (but after the IS_ERR(rt) condition), get rid of th

Re: [PATCH net-next v3 3/7] vxlan: simplify exception handling

2016-11-15 Thread Jiri Benc
On Tue, 15 Nov 2016 08:40:58 -0800, Pravin Shelar wrote: > On Tue, Nov 15, 2016 at 6:30 AM, Jiri Benc wrote: > > It would be a bit cleaner to do this assignment just after rt is > > assigned (but after the IS_ERR(rt) condition), get rid of the added > > ip_rt_put call above and move the existing i

Re: [PATCH net-next v3 3/7] vxlan: simplify exception handling

2016-11-15 Thread Pravin Shelar
On Tue, Nov 15, 2016 at 6:30 AM, Jiri Benc wrote: > On Sun, 13 Nov 2016 20:43:54 -0800, Pravin B Shelar wrote: >> @@ -1927,13 +1923,13 @@ static void vxlan_xmit_one(struct sk_buff *skb, >> struct net_device *dev, >> struct ip_tunnel_info *info; >> struct vxlan_dev *vxlan = netdev_priv

Re: [PATCH net-next v3 3/7] vxlan: simplify exception handling

2016-11-15 Thread Jiri Benc
On Sun, 13 Nov 2016 20:43:54 -0800, Pravin B Shelar wrote: > @@ -1927,13 +1923,13 @@ static void vxlan_xmit_one(struct sk_buff *skb, > struct net_device *dev, > struct ip_tunnel_info *info; > struct vxlan_dev *vxlan = netdev_priv(dev); > struct sock *sk; > - struct rtable *rt