Re: [PATCH net-next v3 3/6] virtio_net: support device stats

2024-03-11 Thread Jakub Kicinski
On Mon, 11 Mar 2024 18:48:45 +0800 Xuan Zhuo wrote: > On Thu, 7 Mar 2024 08:50:21 -0800, Jakub Kicinski wrote: > > CC: Willem and some driver folks for more input, context: extending > > https://lore.kernel.org/all/20240306195509.1502746-1-k...@kernel.org/ > > to cover virtio stats. > > > > On Tue

Re: [PATCH net-next v3 3/6] virtio_net: support device stats

2024-03-11 Thread Xuan Zhuo
On Thu, 7 Mar 2024 08:50:21 -0800, Jakub Kicinski wrote: > CC: Willem and some driver folks for more input, context: extending > https://lore.kernel.org/all/20240306195509.1502746-1-k...@kernel.org/ > to cover virtio stats. > > On Tue, 27 Feb 2024 16:03:00 +0800 Xuan Zhuo wrote: > > +static const

Re: [PATCH net-next v3 3/6] virtio_net: support device stats

2024-03-07 Thread Jakub Kicinski
CC: Willem and some driver folks for more input, context: extending https://lore.kernel.org/all/20240306195509.1502746-1-k...@kernel.org/ to cover virtio stats. On Tue, 27 Feb 2024 16:03:00 +0800 Xuan Zhuo wrote: > +static const struct virtnet_stat_desc virtnet_stats_rx_basic_desc[] = { > + VI

Re: [PATCH net-next v3 3/6] virtio_net: support device stats

2024-02-29 Thread kernel test robot
Hi Xuan, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Xuan-Zhuo/virtio_net-introduce-device-stats-feature-and-structures/20240227-161123 base: net-next/main patch link: https://lor

Re: [PATCH net-next v3 3/6] virtio_net: support device stats

2024-02-27 Thread Simon Horman
On Tue, Feb 27, 2024 at 04:03:00PM +0800, Xuan Zhuo wrote: > As the spec > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > > make virtio-net support getting the stats from the device by ethtool -S > . > > Signed-off-by: Xuan Zhuo ... > +static int vi

Re: [PATCH net-next v3 3/6] virtio_net: support device stats

2024-02-27 Thread Jiri Pirko
Tue, Feb 27, 2024 at 09:03:00AM CET, xuanz...@linux.alibaba.com wrote: >As the spec >https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > >make virtio-net support getting the stats from the device by ethtool -S >. Would be nice to have example output of this