RE: [PATCH net-next v3 0/5] net: dsa: remove .set_addr

2017-10-16 Thread Rodney Cummings
.kernel.org; > ker...@savoirfairelinux.com; David S. Miller ; > Florian Fainelli ; David Laight > > Subject: Re: [PATCH net-next v3 0/5] net: dsa: remove .set_addr > > > How do you guarantee that this MAC address is used for PAUSE, and only > for PAUSE? > > That is the only thing th

Re: [PATCH net-next v3 0/5] net: dsa: remove .set_addr

2017-10-16 Thread Andrew Lunn
> How do you guarantee that this MAC address is used for PAUSE, and only for > PAUSE? That is the only thing the data sheet says this MAC address is used for. Andrew

RE: [PATCH net-next v3 0/5] net: dsa: remove .set_addr

2017-10-16 Thread Rodney Cummings
.com; David S. Miller ; > Florian Fainelli ; David Laight > > Subject: Re: [PATCH net-next v3 0/5] net: dsa: remove .set_addr > > On Mon, Oct 16, 2017 at 04:28:04PM +, Rodney Cummings wrote: > > Hi Andrew, > > > > I may have misunderstood. > > > > If

Re: [PATCH net-next v3 0/5] net: dsa: remove .set_addr

2017-10-16 Thread Andrew Lunn
On Mon, Oct 16, 2017 at 04:28:04PM +, Rodney Cummings wrote: > Hi Andrew, > > I may have misunderstood. > > If this MAC address is the destination Nope. This is the source address, for Pause frames. > My concern is that for a source MAC address, a local random MAC > address is not safe in a

Re: [PATCH net-next v3 0/5] net: dsa: remove .set_addr

2017-10-16 Thread Andrew Lunn
On Mon, Oct 16, 2017 at 04:30:34PM +, David Laight wrote: > From: Andrew Lunn > > Sent: 16 October 2017 17:10 > ... > > So, received Pause frames never leave the MAC. They don't get bridged, > > nor do they get passed up for host processing. They are purely point > > to point between two MAC pe

RE: [PATCH net-next v3 0/5] net: dsa: remove .set_addr

2017-10-16 Thread David Laight
From: Andrew Lunn > Sent: 16 October 2017 17:10 ... > So, received Pause frames never leave the MAC. They don't get bridged, > nor do they get passed up for host processing. They are purely point > to point between two MAC peers. The destination is unambiguous. It is > simple the other MAC peer. Th

RE: [PATCH net-next v3 0/5] net: dsa: remove .set_addr

2017-10-16 Thread Rodney Cummings
@vger.kernel.org; > ker...@savoirfairelinux.com; David S. Miller ; > Florian Fainelli ; David Laight > > Subject: Re: [PATCH net-next v3 0/5] net: dsa: remove .set_addr > > On Mon, Oct 16, 2017 at 03:23:42PM +, Rodney Cummings wrote: > > I am concerned about this propos

Re: [PATCH net-next v3 0/5] net: dsa: remove .set_addr

2017-10-16 Thread Andrew Lunn
On Mon, Oct 16, 2017 at 03:23:42PM +, Rodney Cummings wrote: > I am concerned about this proposed change. > > According to IEEE Std 802.1Q, a "higher layer entity" (i.e. end > station) that is internal to the bridge (i.e. switch) can use the > same individual global MAC address that the switch

RE: [PATCH net-next v3 0/5] net: dsa: remove .set_addr

2017-10-16 Thread Rodney Cummings
I am concerned about this proposed change. According to IEEE Std 802.1Q, a "higher layer entity" (i.e. end station) that is internal to the bridge (i.e. switch) can use the same individual global MAC address that the switch is using. That behavior is common. Use of a local semi-random MAC addre

Re: [PATCH net-next v3 0/5] net: dsa: remove .set_addr

2017-10-14 Thread David Miller
From: Vivien Didelot Date: Fri, 13 Oct 2017 14:18:04 -0400 > An Ethernet switch may support having a MAC address, which can be used > as the switch's source address in transmitted full-duplex Pause frames. > > If a DSA switch supports the related .set_addr operation, the DSA core > sets the mast