Re: [PATCH net-next v3] net: Add fib rules at vrf device create

2015-12-09 Thread David Ahern
On 12/9/15 3:22 PM, David Miller wrote: Just write a script already... Why do you think this took so long to bubble up? I wrote a script back in July -- well before VRF was accepted into your tree -- that I use for testing. This request comes from other users starting to work with VRFs. --

Re: [PATCH net-next v3] net: Add fib rules at vrf device create

2015-12-09 Thread David Miller
From: David Ahern Date: Wed, 9 Dec 2015 15:05:06 -0700 > On 12/9/15 1:13 PM, David Miller wrote: >> The new attributes make things more complex, because ever _VALID_ tool >> much accomodate the existing situation and be able to perform all of >> the commands above if they are executed on an older

Re: [PATCH net-next v3] net: Add fib rules at vrf device create

2015-12-09 Thread David Ahern
On 12/9/15 1:13 PM, David Miller wrote: The new attributes make things more complex, because ever _VALID_ tool much accomodate the existing situation and be able to perform all of the commands above if they are executed on an older kernel. So the new attributes make things worse, not better. D

Re: [PATCH net-next v3] net: Add fib rules at vrf device create

2015-12-09 Thread David Miller
From: David Ahern Date: Wed, 9 Dec 2015 09:43:32 -0800 > VRFs require ip rules for route lookups to work properly. Currently > creating a VRF means instantiating a device and then adding the 4 ip > and ip6 rules: > > ip link add vrf-${VRF} type vrf table ${TBID} > ip link set vrf-${VRF}