Re: [PATCH net-next V2 1/2] net-next: use five-tuple hash for sk_txhash

2017-12-03 Thread Tom Herbert
On Sun, Dec 3, 2017 at 7:38 AM, David Miller wrote: > From: Shaohua Li > Date: Fri, 1 Dec 2017 13:00:43 -0800 > >> This causes our router doesn't correctly close tcp connection. > > Then please fix your router. > > How many times do I have to say this... The flowlabel is not part of > the socke

Re: [PATCH net-next V2 1/2] net-next: use five-tuple hash for sk_txhash

2017-12-03 Thread David Miller
From: Shaohua Li Date: Fri, 1 Dec 2017 13:00:43 -0800 > This causes our router doesn't correctly close tcp connection. Then please fix your router. How many times do I have to say this... The flowlabel is not part of the socket connection identity, therefore you cannot use it for connection s

Re: [PATCH net-next V2 1/2] net-next: use five-tuple hash for sk_txhash

2017-12-01 Thread Tom Herbert
On Fri, Dec 1, 2017 at 1:00 PM, Shaohua Li wrote: > From: Shaohua Li > > We are using sk_txhash to calculate flowlabel, but sk_txhash isn't > always available, for example, in inet_timewait_sock. This causes > problem for reset packet, which will have a different flowlabel. This > causes our rout