On Fri, 29 Jan 2021 12:07:23 -0800
Jakub Kicinski wrote:
> On Fri, 29 Jan 2021 20:47:41 +0100 Eric Dumazet wrote:
> > On 1/29/21 8:35 PM, Jakub Kicinski wrote:
> >
> > > kdoc didn't complain, and as you say it's already a mess, plus it's
> > > two screen-fulls of scrolling away...
> > >
> >
On Fri, 29 Jan 2021 15:00:58 +0100
Jesper Dangaard Brouer wrote:
> On Fri, 29 Jan 2021 14:33:02 +0100
> Eric Dumazet wrote:
>
> > On 1/26/21 6:39 PM, Jesper Dangaard Brouer wrote:
> > > The current layout of net_device is not optimal for cacheline usage.
> > >
[...]
> > > @@ -1877,6 +1876,23
On Fri, 29 Jan 2021 20:47:41 +0100 Eric Dumazet wrote:
> On 1/29/21 8:35 PM, Jakub Kicinski wrote:
>
> > kdoc didn't complain, and as you say it's already a mess, plus it's
> > two screen-fulls of scrolling away...
> >
> > I think converting to inline kdoc of members would be an improvement,
> >
On 1/29/21 8:35 PM, Jakub Kicinski wrote:
> kdoc didn't complain, and as you say it's already a mess, plus it's
> two screen-fulls of scrolling away...
>
> I think converting to inline kdoc of members would be an improvement,
> if you want to sign up for that? Otherwise -EDIDNTCARE on my side
On Fri, 29 Jan 2021 11:46:42 +0100 Jesper Dangaard Brouer wrote:
> > On Thu, 28 Jan 2021 20:51:23 -0700
> > David Ahern wrote:
> > > A long over due look at the organization of this struct.
>
> Yes, I was surprised that the cache-lines used in fast-path was this
> spread out.
I tried measuring
On Thu, 28 Jan 2021 20:51:23 -0700
David Ahern wrote:
> On 1/26/21 10:39 AM, Jesper Dangaard Brouer wrote:
> > The current layout of net_device is not optimal for cacheline usage.
> >
> > The member adj_list.lower linked list is split between cacheline 2 and 3.
> > The ifindex is placed together
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 26 Jan 2021 18:39:39 +0100 you wrote:
> The current layout of net_device is not optimal for cacheline usage.
>
> The member adj_list.lower linked list is split between cacheline 2 and 3.
> The ifindex is placed tog
On 1/26/21 10:39 AM, Jesper Dangaard Brouer wrote:
> The current layout of net_device is not optimal for cacheline usage.
>
> The member adj_list.lower linked list is split between cacheline 2 and 3.
> The ifindex is placed together with stats (struct net_device_stats),
> although most modern driv
