Re: [PATCH net-next RFC v1 06/10] nvme-tcp: Add DDP data-path

2020-11-09 Thread Sagi Grimberg
static int nvme_tcp_recv_data(struct nvme_tcp_queue *queue, struct sk_buff *skb, @@ -1115,6 +1222,7 @@ static int nvme_tcp_try_send_cmd_pdu(struct nvme_tcp_request *req) bool inline_data = nvme_tcp_has_inline_data(req); u8 hdgst = nvme_tcp_hdgst_len(queue); int len

Re: [PATCH net-next RFC v1 06/10] nvme-tcp: Add DDP data-path

2020-11-08 Thread Boris Pismenny
On 09/10/2020 2:00, Sagi Grimberg wrote: >>>   static >>>   int nvme_tcp_offload_socket(struct nvme_tcp_queue *queue, >>>   struct nvme_tcp_config *config) >>> @@ -630,6 +720,7 @@ static void nvme_tcp_error_recovery(struct >>> nvme_ctrl *ctrl) >>>   static int nvme_tcp_process_n

Re: [PATCH net-next RFC v1 06/10] nvme-tcp: Add DDP data-path

2020-11-08 Thread Boris Pismenny
On 09/10/2020 1:29, Sagi Grimberg wrote: > >> static int nvme_tcp_recv_data(struct nvme_tcp_queue *queue, struct sk_buff >> *skb, >> @@ -1115,6 +1222,7 @@ static int nvme_tcp_try_send_cmd_pdu(struct >> nvme_tcp_request *req) >> bool inline_data = nvme_tcp_has_inline_data(req); >> u

Re: [PATCH net-next RFC v1 06/10] nvme-tcp: Add DDP data-path

2020-10-08 Thread Sagi Grimberg
  static   int nvme_tcp_offload_socket(struct nvme_tcp_queue *queue,   struct nvme_tcp_config *config) @@ -630,6 +720,7 @@ static void nvme_tcp_error_recovery(struct nvme_ctrl *ctrl)   static int nvme_tcp_process_nvme_cqe(struct nvme_tcp_queue *queue,   struct nvme_com

Re: [PATCH net-next RFC v1 06/10] nvme-tcp: Add DDP data-path

2020-10-08 Thread Sagi Grimberg
bool nvme_tcp_resync_request(struct sock *sk, u32 seq, u32 flags); +void nvme_tcp_ddp_teardown_done(void *ddp_ctx); const struct tcp_ddp_ulp_ops nvme_tcp_ddp_ulp_ops __read_mostly = { + .resync_request = nvme_tcp_resync_request, + .ddp_teardown_done = nvme_tcp_ddp