Re: [PATCH net-next 3/3] tcp: implement head drops in backlog queue

2018-11-21 Thread Eric Dumazet
On Wed, Nov 21, 2018 at 4:55 PM Yuchung Cheng wrote: > > To clarify I do think this patch set is overall useful so I only > wanted to discuss the specifics of the head drop. > > It occurs to me we check the limit differently (one w/ 64KB more), so > we may overcommit and trim more often than neces

Re: [PATCH net-next 3/3] tcp: implement head drops in backlog queue

2018-11-21 Thread Yuchung Cheng
On Wed, Nov 21, 2018 at 4:18 PM, Eric Dumazet wrote: > On Wed, Nov 21, 2018 at 3:52 PM Eric Dumazet wrote: >> This is basically what the patch does, the while loop breaks when we have >> freed >> just enough skbs. > > Also this is the patch we tested with Jean-Louis on his host, bring > very nic

Re: [PATCH net-next 3/3] tcp: implement head drops in backlog queue

2018-11-21 Thread Eric Dumazet
On Wed, Nov 21, 2018 at 3:52 PM Eric Dumazet wrote: > This is basically what the patch does, the while loop breaks when we have > freed > just enough skbs. Also this is the patch we tested with Jean-Louis on his host, bring very nice results, even from an old stack sender (the one that had probl

Re: [PATCH net-next 3/3] tcp: implement head drops in backlog queue

2018-11-21 Thread Eric Dumazet
On Wed, Nov 21, 2018 at 3:47 PM Yuchung Cheng wrote: > > On Wed, Nov 21, 2018 at 2:47 PM, Eric Dumazet wrote: > > > > > > On 11/21/2018 02:40 PM, Yuchung Cheng wrote: > >> On Wed, Nov 21, 2018 at 9:52 AM, Eric Dumazet wrote: > >>> Under high stress, and if GRO or coalescing does not help, > >>>

Re: [PATCH net-next 3/3] tcp: implement head drops in backlog queue

2018-11-21 Thread Yuchung Cheng
On Wed, Nov 21, 2018 at 2:47 PM, Eric Dumazet wrote: > > > On 11/21/2018 02:40 PM, Yuchung Cheng wrote: >> On Wed, Nov 21, 2018 at 9:52 AM, Eric Dumazet wrote: >>> Under high stress, and if GRO or coalescing does not help, >>> we better make room in backlog queue to be able to keep latest >>> pac

Re: [PATCH net-next 3/3] tcp: implement head drops in backlog queue

2018-11-21 Thread Eric Dumazet
On 11/21/2018 02:40 PM, Yuchung Cheng wrote: > On Wed, Nov 21, 2018 at 9:52 AM, Eric Dumazet wrote: >> Under high stress, and if GRO or coalescing does not help, >> we better make room in backlog queue to be able to keep latest >> packet coming. >> >> This generally helps fast recovery, given t

Re: [PATCH net-next 3/3] tcp: implement head drops in backlog queue

2018-11-21 Thread Yuchung Cheng
On Wed, Nov 21, 2018 at 9:52 AM, Eric Dumazet wrote: > Under high stress, and if GRO or coalescing does not help, > we better make room in backlog queue to be able to keep latest > packet coming. > > This generally helps fast recovery, given that we often receive > packets in order. I like the be