RE: [PATCH net-next 2/4] xen-netback: add control protocol implementation

2016-05-10 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 10 May 2016 14:29 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; Wei Liu > Subject: Re: [PATCH net-next 2/4] xen-netback: add control protocol > implementatio

Re: [PATCH net-next 2/4] xen-netback: add control protocol implementation

2016-05-10 Thread Wei Liu
On Thu, May 05, 2016 at 12:19:28PM +0100, Paul Durrant wrote: > My recent patch to include/xen/interface/io/netif.h defines a new shared > ring (in addition to the rx and tx rings) for passing control messages > from a VM frontend driver to a backend driver. > > A previous patch added the necessar

RE: [PATCH net-next 2/4] xen-netback: add control protocol implementation

2016-05-09 Thread Paul Durrant
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: 07 May 2016 20:09 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; Wei Liu > Subject: Re: [PATCH net-next 2/4] xen-netback: add control protocol > implement

Re: [PATCH net-next 2/4] xen-netback: add control protocol implementation

2016-05-07 Thread David Miller
From: Paul Durrant Date: Thu, 5 May 2016 12:19:28 +0100 > +struct xenvif_hash_cache { > + rwlock_t lock; You really don't want to lock on every SKB hash computation like this, turn this into a spin lock for locking the write side and use RCU locking for lookup and usage. THanks.