Re: [PATCH net-next 2/3] tcp: ulp: add functions to dump ulp-specific information

2019-08-19 Thread Jakub Kicinski
On Mon, 19 Aug 2019 15:32:09 +0200, Davide Caratti wrote: > On Thu, 2019-08-15 at 14:38 -0700, Jakub Kicinski wrote: > > On Thu, 15 Aug 2019 20:46:01 +0200, Eric Dumazet wrote: > > > On 8/15/19 6:00 PM, Davide Caratti wrote: > > > > + if (net_admin) { > > > > + const struct tc

Re: [PATCH net-next 2/3] tcp: ulp: add functions to dump ulp-specific information

2019-08-19 Thread Davide Caratti
On Thu, 2019-08-15 at 14:38 -0700, Jakub Kicinski wrote: > On Thu, 15 Aug 2019 20:46:01 +0200, Eric Dumazet wrote: hello Eric and Jakub, thanks a lot for looking at this. > > On 8/15/19 6:00 PM, Davide Caratti wrote: > > > > > > > > + if (net_admin) { > > > + const struct tcp_ulp_ops *

Re: [PATCH net-next 2/3] tcp: ulp: add functions to dump ulp-specific information

2019-08-15 Thread Jakub Kicinski
On Thu, 15 Aug 2019 20:46:01 +0200, Eric Dumazet wrote: > On 8/15/19 6:00 PM, Davide Caratti wrote: > > > > > + if (net_admin) { > > + const struct tcp_ulp_ops *ulp_ops; > > + > > + rcu_read_lock(); > > + ulp_ops = icsk->icsk_ulp_ops; > > + if (ulp_ops)

Re: [PATCH net-next 2/3] tcp: ulp: add functions to dump ulp-specific information

2019-08-15 Thread Eric Dumazet
On 8/15/19 6:00 PM, Davide Caratti wrote: > > + if (net_admin) { > + const struct tcp_ulp_ops *ulp_ops; > + > + rcu_read_lock(); > + ulp_ops = icsk->icsk_ulp_ops; > + if (ulp_ops) > + err = tcp_diag_put_ulp(skb, sk, ulp_o