Re: [PATCH net-next 2/2] virtio-net: simplify XDP handling in small buffer

2018-03-01 Thread Jason Wang
On 2018年03月01日 17:15, Jesper Dangaard Brouer wrote: On Thu, 1 Mar 2018 16:49:24 +0800 Jason Wang wrote: 2. This can easily cause out-of-order packets. I may miss something, but it looks to me packets were still delivered in order? Or you mean the packets that was dropped by cpumap? No. Pac

Re: [PATCH net-next 2/2] virtio-net: simplify XDP handling in small buffer

2018-03-01 Thread Jesper Dangaard Brouer
On Thu, 1 Mar 2018 16:49:24 +0800 Jason Wang wrote: > > 2. This can easily cause out-of-order packets. > > I may miss something, but it looks to me packets were still delivered > in order? Or you mean the packets that was dropped by cpumap? No. Packets can now travel two code paths to the egr

Re: [PATCH net-next 2/2] virtio-net: simplify XDP handling in small buffer

2018-03-01 Thread Jason Wang
On 2018年03月01日 16:02, Jesper Dangaard Brouer wrote: On Thu, 1 Mar 2018 11:19:05 +0800 Jason Wang wrote: We used to do data copy through xdp_linearize_page() for the buffer without sufficient headroom, it brings extra complexity without helping for the performance. So this patch remove it an

Re: [PATCH net-next 2/2] virtio-net: simplify XDP handling in small buffer

2018-03-01 Thread Jesper Dangaard Brouer
On Thu, 1 Mar 2018 11:19:05 +0800 Jason Wang wrote: > We used to do data copy through xdp_linearize_page() for the buffer > without sufficient headroom, it brings extra complexity without > helping for the performance. So this patch remove it and switch to use > generic XDP routine to handle th