Re: [PATCH net-next 2/2] openvswitch: Add timeout support to ct action

2019-03-23 Thread kbuild test robot
Hi Yi-Hung, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Yi-Hung-Wei/netfilter-Export-nf_ct_destroy_timeout/20190323-094843 reproduce: # apt-get install sparse make ARCH=x86_6

Re: [PATCH net-next 2/2] openvswitch: Add timeout support to ct action

2019-03-22 Thread kbuild test robot
Hi Yi-Hung, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Yi-Hung-Wei/netfilter-Export-nf_ct_destroy_timeout/20190323-094843 config: i386-randconfig-x004-201911 (attached as .config) compiler: gcc-7

Re: [PATCH net-next 2/2] openvswitch: Add timeout support to ct action

2019-03-21 Thread Yi-Hung Wei
> > +static void ovs_ct_add_timeout(struct net *net, struct nf_conn *ct, > > + const char *timeout_name, u16 l3num, u8 > > l4num) > > +{ > This code looks very similar to xt_ct_set_timeout(), can you refactor > it to avoid code duplication? Thanks Prvain's feedback. I

Re: [PATCH net-next 2/2] openvswitch: Add timeout support to ct action

2019-03-20 Thread Pravin Shelar
On Wed, Mar 20, 2019 at 2:19 PM Yi-Hung Wei wrote: > > Add support for fine-grain timeout support to conntrack action. > The new OVS_CT_ATTR_TIMEOUT attribute of the conntrack action > specifies a timeout to be associated with this connection. > If no timeout is specified, it acts as is, that is t