On 6/25/19 4:47 PM, Jakub Kicinski wrote:
On Thu, 20 Jun 2019 13:24:18 -0700, Shannon Nelson wrote:
+ /* filter out the no-change cases */
+ if ((link_up && netif_carrier_ok(netdev)) ||
+ (!link_up && !netif_carrier_ok(netdev)))
nit: these are both bools, you can compare t
On Thu, 20 Jun 2019 13:24:18 -0700, Shannon Nelson wrote:
> + /* filter out the no-change cases */
> + if ((link_up && netif_carrier_ok(netdev)) ||
> + (!link_up && !netif_carrier_ok(netdev)))
nit: these are both bools, you can compare them:
if (link_up == netif_carrier_ok
