Re: [PATCH net-next 1/7] net: Don't disable interrupts in napi_alloc_frag()

2019-05-31 Thread Sebastian Andrzej Siewior
On 2019-05-29 15:48:51 [-0700], Eric Dumazet wrote: > > + > > + fragsz = SKB_DATA_ALIGN(fragsz); > > + if (irqs_disabled()) { > > > What is the difference between this prior test, and the following ? > > if (in_irq() || irqs_disabled()) > > I am asking because I see the latter being used in

Re: [PATCH net-next 1/7] net: Don't disable interrupts in napi_alloc_frag()

2019-05-29 Thread Eric Dumazet
On 5/29/19 3:15 PM, Sebastian Andrzej Siewior wrote: > netdev_alloc_frag() can be used from any context and is used by NAPI > and non-NAPI drivers. Non-NAPI drivers use it in interrupt context > and NAPI drivers use it during initial allocation (->ndo_open() or > ->ndo_change_mtu()). Some NAPI d