RE: [PATCH net-next 1/3] ibmvnic: Enable scatter-gather support

2017-10-27 Thread David Laight
From: Thomas Falcon > Sent: 26 October 2017 18:52 ... > >>memset(dst, 0, adapter->req_mtu); > > Seems unnecessary. > > I removed that bit, and so far you seem to be right :) . I'd check that short frames are padded with zeros. David

Re: [PATCH net-next 1/3] ibmvnic: Enable scatter-gather support

2017-10-26 Thread Thomas Falcon
On 10/18/2017 06:04 AM, David Laight wrote: > From: Thomas Falcon >> Sent: 17 October 2017 18:37 >> This patch enables scatter gather support. Since there is no >> HW/FW scatter-gather support at this time, the driver needs to >> loop through each fragment and copy it to a contiguous, pre-mapped >>

RE: [PATCH net-next 1/3] ibmvnic: Enable scatter-gather support

2017-10-18 Thread David Laight
From: Thomas Falcon > Sent: 17 October 2017 18:37 > This patch enables scatter gather support. Since there is no > HW/FW scatter-gather support at this time, the driver needs to > loop through each fragment and copy it to a contiguous, pre-mapped > buffer entry. ... > offset = index * adapter