Re: [PATCH net-next 1/2] net: dsa: Add support for a switch reset gpio

2015-11-19 Thread Andrew Lunn
On Thu, Nov 19, 2015 at 09:39:11AM +0100, Neil Armstrong wrote: > Hi Andrew, > > On 11/19/2015 12:29 AM, Andrew Lunn wrote: > > + gpio = of_get_named_gpio_flags(child, "reset-gpios", 0, > > + &flags); > > + if (gpio_is_valid(gpio)) { > >

Re: [PATCH net-next 1/2] net: dsa: Add support for a switch reset gpio

2015-11-19 Thread Neil Armstrong
Hi Andrew, On 11/19/2015 12:29 AM, Andrew Lunn wrote: > + gpio = of_get_named_gpio_flags(child, "reset-gpios", 0, > +&flags); > + if (gpio_is_valid(gpio)) { > + ret = devm_gpio_request_one(dev, gpio, flags, > +

Re: [PATCH net-next 1/2] net: dsa: Add support for a switch reset gpio

2015-11-18 Thread Andrew Lunn
> index 1eba07feb34a..39cd19eaaf4e 100644 > --- a/net/dsa/dsa.c > +++ b/net/dsa/dsa.c > @@ -21,6 +21,8 @@ > #include > #include > #include > +#include Comment to self: That include should not be there. I will post a v2 once the discussion has stopped. Andrew -- To unsubscribe from this