Re: [PATCH net-next 0/2] Add ethtool set regs support

2016-12-12 Thread Florian Fainelli
On 12/11/2016 07:22 AM, Andrew Lunn wrote: > On Sun, Dec 11, 2016 at 02:18:00PM +0200, Saeed Mahameed wrote: >> On Wed, Dec 7, 2016 at 4:41 AM, Andrew Lunn wrote: >>> On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote: Hi Dave, This series adds the support for setting de

Re: [PATCH net-next 0/2] Add ethtool set regs support

2016-12-11 Thread Andrew Lunn
On Sun, Dec 11, 2016 at 02:18:00PM +0200, Saeed Mahameed wrote: > On Wed, Dec 7, 2016 at 4:41 AM, Andrew Lunn wrote: > > On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote: > >> Hi Dave, > >> > >> This series adds the support for setting device registers from user > >> space ethtool. >

Re: [PATCH net-next 0/2] Add ethtool set regs support

2016-12-11 Thread Saeed Mahameed
On Wed, Dec 7, 2016 at 4:57 AM, David Miller wrote: > From: Andrew Lunn > Date: Wed, 7 Dec 2016 03:41:43 +0100 > >> On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote: >>> Hi Dave, >>> >>> This series adds the support for setting device registers from user >>> space ethtool. >> >> Is

Re: [PATCH net-next 0/2] Add ethtool set regs support

2016-12-11 Thread Saeed Mahameed
On Wed, Dec 7, 2016 at 4:41 AM, Andrew Lunn wrote: > On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote: >> Hi Dave, >> >> This series adds the support for setting device registers from user >> space ethtool. > > Is this not the start of allowing binary only drivers in user space? > I

Re: [PATCH net-next 0/2] Add ethtool set regs support

2016-12-11 Thread Saeed Mahameed
On Wed, Dec 7, 2016 at 12:45 AM, Stephen Hemminger wrote: > On Wed, 7 Dec 2016 00:33:08 +0200 > Saeed Mahameed wrote: > >> This simple ethool change will give HW vendors the flexibility to set >> pure HW configurations (not directly related to netdev resources states >> and rings), without the n

Re: [PATCH net-next 0/2] Add ethtool set regs support

2016-12-06 Thread David Miller
From: Andrew Lunn Date: Wed, 7 Dec 2016 03:41:43 +0100 > On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote: >> Hi Dave, >> >> This series adds the support for setting device registers from user >> space ethtool. > > Is this not the start of allowing binary only drivers in user spac

Re: [PATCH net-next 0/2] Add ethtool set regs support

2016-12-06 Thread Andrew Lunn
On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote: > Hi Dave, > > This series adds the support for setting device registers from user > space ethtool. Is this not the start of allowing binary only drivers in user space? Do we want this? > mlx5 driver have registers allowed access l

Re: [PATCH net-next 0/2] Add ethtool set regs support

2016-12-06 Thread Stephen Hemminger
On Wed, 7 Dec 2016 00:33:08 +0200 Saeed Mahameed wrote: > This simple ethool change will give HW vendors the flexibility to set > pure HW configurations (not directly related to netdev resources states > and rings), without the need of vendor proprietary tools and hacks. The danger is you need