Re: [PATCH net-next] tcp: enhance tcp collapsing

2016-11-01 Thread Eric Dumazet
On Tue, 2016-11-01 at 10:39 -0700, Eric Dumazet wrote: > Thanks Neal. > > David please hold this patch, further tests show an issue I need to > track and fix. The issue is that the right skb can be a FIN packet with no data, merged to a left skb with frag(s). Thus I need to call skb_copy_bits()

Re: [PATCH net-next] tcp: enhance tcp collapsing

2016-11-01 Thread Eric Dumazet
On Tue, 2016-11-01 at 12:35 -0400, Neal Cardwell wrote: > On Tue, Nov 1, 2016 at 11:32 AM, Eric Dumazet wrote: > > > > From: Eric Dumazet > > > > As Ilya Lesokhin suggested, we can collapse two skbs at retransmit > > time even if the skb at the right has fragments. > > > > We simply have to use m

Re: [PATCH net-next] tcp: enhance tcp collapsing

2016-11-01 Thread Neal Cardwell
On Tue, Nov 1, 2016 at 11:32 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > As Ilya Lesokhin suggested, we can collapse two skbs at retransmit > time even if the skb at the right has fragments. > > We simply have to use more generic skb_copy_bits() instead of > skb_copy_from_linear_data() in