Re: [PATCH net-next] rtnetlink: Fix null-ptr-deref in rtnl_newlink

2018-06-01 Thread Kees Cook
On Fri, Jun 1, 2018 at 1:26 AM, Eric Dumazet wrote: > On Fri, Jun 1, 2018 at 4:18 AM Prashant Bhole > wrote: >> >> In rtnl_newlink(), NULL check is performed on m_ops however member of >> ops is accessed. Fixed by accessing member of m_ops instead of ops. >> >> [ 345.432629] BUG: KASAN: null-ptr

Re: [PATCH net-next] rtnetlink: Fix null-ptr-deref in rtnl_newlink

2018-06-01 Thread David Miller
From: Prashant Bhole Date: Fri, 1 Jun 2018 17:16:58 +0900 > In rtnl_newlink(), NULL check is performed on m_ops however member of > ops is accessed. Fixed by accessing member of m_ops instead of ops. > > [ 345.432629] BUG: KASAN: null-ptr-deref in rtnl_newlink+0x400/0x1110 > [ 345.432629] Rea

Re: [PATCH net-next] rtnetlink: Fix null-ptr-deref in rtnl_newlink

2018-06-01 Thread Ido Schimmel
On Fri, Jun 01, 2018 at 05:16:58PM +0900, Prashant Bhole wrote: > In rtnl_newlink(), NULL check is performed on m_ops however member of > ops is accessed. Fixed by accessing member of m_ops instead of ops. > > [ 345.432629] BUG: KASAN: null-ptr-deref in rtnl_newlink+0x400/0x1110 > [ 345.432629]

Re: [PATCH net-next] rtnetlink: Fix null-ptr-deref in rtnl_newlink

2018-06-01 Thread Eric Dumazet
On Fri, Jun 1, 2018 at 4:18 AM Prashant Bhole wrote: > > In rtnl_newlink(), NULL check is performed on m_ops however member of > ops is accessed. Fixed by accessing member of m_ops instead of ops. > > [ 345.432629] BUG: KASAN: null-ptr-deref in rtnl_newlink+0x400/0x1110 > [ 345.432629] Read of s