Re: [PATCH net-next] qed*: Utilize FW 8.33.1.0

2017-12-22 Thread kbuild test robot
Hi Tomer, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Tomer-Tayar/qed-Utilize-FW-8-33-1-0/20171221-180506 config: x86_64-randconfig-s0-12221644 (attached as .config) compiler: gcc-6 (Debian 6.4.0-

Re: [PATCH net-next] qed*: Utilize FW 8.33.1.0

2017-12-21 Thread kbuild test robot
Hi Tomer, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Tomer-Tayar/qed-Utilize-FW-8-33-1-0/20171221-180506 config: xtensa-allmodconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 7

Re: [PATCH net-next] qed*: Utilize FW 8.33.1.0

2017-12-20 Thread David Miller
From: Jakub Kicinski Date: Tue, 19 Dec 2017 15:46:51 -0800 > On Tue, 19 Dec 2017 16:05:23 +0200, Tomer Tayar wrote: >> Sorry for the very long patch. >> The firmware changes are spread all over w/o a good modularity. > > Rings false. Significant portion of this patch is just whitespace > and c

Re: [PATCH net-next] qed*: Utilize FW 8.33.1.0

2017-12-19 Thread Jakub Kicinski
On Tue, 19 Dec 2017 16:05:23 +0200, Tomer Tayar wrote: > Sorry for the very long patch. > The firmware changes are spread all over w/o a good modularity. Rings false. Significant portion of this patch is just whitespace and comment changes.