Re: [PATCH net-next] octeontx2-af: debugfs: delete dead code

2020-12-02 Thread Jakub Kicinski
On Wed, 2 Dec 2020 12:33:00 +0530 Sunil Kovvuri wrote: > On Wed, Dec 2, 2020 at 12:28 PM Dan Carpenter > wrote: > > These debugfs never return NULL so all this code will never be run. > > > > In the normal case, (and in this case particularly), the debugfs > > functions are not supposed to be che

Re: [PATCH net-next] octeontx2-af: debugfs: delete dead code

2020-12-01 Thread Sunil Kovvuri
On Wed, Dec 2, 2020 at 12:28 PM Dan Carpenter wrote: > > These debugfs never return NULL so all this code will never be run. > > In the normal case, (and in this case particularly), the debugfs > functions are not supposed to be checked for errors so all this error > checking code can be safely de