Re: [PATCH net-next] netlink: reduce NLA_POLICY_NESTED{,_ARRAY} arguments

2019-01-25 Thread David Miller
From: Johannes Berg Date: Fri, 25 Jan 2019 20:34:57 +0100 > On Fri, 2019-01-25 at 11:04 -0800, David Miller wrote: >> >> > Dave, it looks like we're the only users of this right now, >> > so let me know if you'd prefer I take it through my tree. >> > Also, this conflicts with the fix I just made

Re: [PATCH net-next] netlink: reduce NLA_POLICY_NESTED{,_ARRAY} arguments

2019-01-25 Thread Johannes Berg
On Fri, 2019-01-25 at 11:04 -0800, David Miller wrote: > > > Dave, it looks like we're the only users of this right now, > > so let me know if you'd prefer I take it through my tree. > > Also, this conflicts with the fix I just made to the place > > where I got it wrong, but obviously the resoluti

Re: [PATCH net-next] netlink: reduce NLA_POLICY_NESTED{,_ARRAY} arguments

2019-01-25 Thread David Miller
From: Johannes Berg Date: Fri, 25 Jan 2019 10:08:28 +0100 > From: Johannes Berg > > In typical cases, there's no need to pass both the maxattr > and the policy array pointer, as the maxattr should just be > ARRAY_SIZE(policy) - 1. Therefore, to be less error prone, > just remove the maxattr arg