Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-27 Thread Chris Mi
On 1/28/2021 7:03 AM, Saeed Mahameed wrote: On Wed, 2021-01-27 at 11:42 +0800, Chris Mi wrote: Could you please tell me what's sparse warnings you hit? https://patchwork.kernel.org/project/netdevbpf/patch/20210127101648.513562-1-...@nvidia.com/ build allmodconfig and build32 OK, I see. Thank

Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-27 Thread Jakub Kicinski
On Tue, 26 Jan 2021 20:50:28 -0800 Saeed Mahameed wrote: > On Tue, 2021-01-26 at 18:49 -0800, Jakub Kicinski wrote: > > On Tue, 26 Jan 2021 22:59:29 +0800 Chris Mi wrote: > > > In order to send sampled packets to userspace, NIC driver calls > > > psample api directly. But it creates a hard depend

Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-27 Thread Saeed Mahameed
On Wed, 2021-01-27 at 11:42 +0800, Chris Mi wrote: > Could you please tell me what's sparse warnings you hit? https://patchwork.kernel.org/project/netdevbpf/patch/20210127101648.513562-1-...@nvidia.com/ build allmodconfig and build32

Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-26 Thread kernel test robot
Hi Chris, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Chris-Mi/net-psample-Introduce-stubs-to-remove-NIC-driver-dependency/20210127-082451 base: https://git.kernel.org/pub/scm/linux/kernel

Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-26 Thread Chris Mi
Hi Jakub, On 1/27/2021 10:49 AM, Jakub Kicinski wrote: On Tue, 26 Jan 2021 22:59:29 +0800 Chris Mi wrote: In order to send sampled packets to userspace, NIC driver calls psample api directly. But it creates a hard dependency on module psample. Introduce psample_ops to remove the hard dependency

Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-26 Thread Saeed Mahameed
On Tue, 2021-01-26 at 18:49 -0800, Jakub Kicinski wrote: > On Tue, 26 Jan 2021 22:59:29 +0800 Chris Mi wrote: > > In order to send sampled packets to userspace, NIC driver calls > > psample api directly. But it creates a hard dependency on module > > psample. Introduce psample_ops to remove the har

Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-26 Thread Jakub Kicinski
On Tue, 26 Jan 2021 22:59:29 +0800 Chris Mi wrote: > In order to send sampled packets to userspace, NIC driver calls > psample api directly. But it creates a hard dependency on module > psample. Introduce psample_ops to remove the hard dependency. > It is initialized when psample module is loaded a