Re: [PATCH net-next] net: phy: print error message in phy_error

2018-12-16 Thread Heiner Kallweit
On 16.12.2018 18:55, Florian Fainelli wrote: > Le 12/16/18 à 9:16 AM, Heiner Kallweit a écrit : >> On 16.12.2018 18:02, Florian Fainelli wrote: >>> Le 12/16/18 à 7:52 AM, Heiner Kallweit a écrit : So far phy_error() silently stops the PHY state machine. If the network driver doesn't infor

Re: [PATCH net-next] net: phy: print error message in phy_error

2018-12-16 Thread Florian Fainelli
Le 12/16/18 à 9:16 AM, Heiner Kallweit a écrit : > On 16.12.2018 18:02, Florian Fainelli wrote: >> Le 12/16/18 à 7:52 AM, Heiner Kallweit a écrit : >>> So far phy_error() silently stops the PHY state machine. If the network >>> driver doesn't inform about a MDIO error then the user may wonder why

Re: [PATCH net-next] net: phy: print error message in phy_error

2018-12-16 Thread Heiner Kallweit
On 16.12.2018 18:02, Florian Fainelli wrote: > Le 12/16/18 à 7:52 AM, Heiner Kallweit a écrit : >> So far phy_error() silently stops the PHY state machine. If the network >> driver doesn't inform about a MDIO error then the user may wonder why >> his network is down. So let's inform the user. >> >

Re: [PATCH net-next] net: phy: print error message in phy_error

2018-12-16 Thread Heiner Kallweit
On 16.12.2018 18:02, Florian Fainelli wrote: > Le 12/16/18 à 7:52 AM, Heiner Kallweit a écrit : >> So far phy_error() silently stops the PHY state machine. If the network >> driver doesn't inform about a MDIO error then the user may wonder why >> his network is down. So let's inform the user. >> >

Re: [PATCH net-next] net: phy: print error message in phy_error

2018-12-16 Thread Florian Fainelli
Le 12/16/18 à 7:52 AM, Heiner Kallweit a écrit : > So far phy_error() silently stops the PHY state machine. If the network > driver doesn't inform about a MDIO error then the user may wonder why > his network is down. So let's inform the user. > > Signed-off-by: Heiner Kallweit Reviewed-by: Flo

Re: [PATCH net-next] net: phy: print error message in phy_error

2018-12-16 Thread Andrew Lunn
On Sun, Dec 16, 2018 at 04:52:21PM +0100, Heiner Kallweit wrote: > So far phy_error() silently stops the PHY state machine. If the network > driver doesn't inform about a MDIO error then the user may wonder why > his network is down. So let's inform the user. > > Signed-off-by: Heiner Kallweit