Re: [PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-07 Thread David Miller
From: Heiner Kallweit Date: Sun, 5 May 2019 19:03:51 +0200 > So far we report symmetric pause only, and we don't consider the local > pause capabilities. Let's properly consider local and remote > capabilities, and report also asymmetric pause. > > Signed-off-by: Heiner Kallweit It looks like

Re: [PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-05 Thread Heiner Kallweit
On 05.05.2019 21:12, Florian Fainelli wrote: > > > On 5/5/2019 12:06 PM, Heiner Kallweit wrote: >> On 05.05.2019 20:46, Florian Fainelli wrote: >>> >>> >>> On 5/5/2019 10:31 AM, Heiner Kallweit wrote: On 05.05.2019 19:10, Florian Fainelli wrote: > > > On 5/5/2019 10:03 AM, Heiner

Re: [PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-05 Thread Heiner Kallweit
On 05.05.2019 20:46, Florian Fainelli wrote: > > > On 5/5/2019 10:31 AM, Heiner Kallweit wrote: >> On 05.05.2019 19:10, Florian Fainelli wrote: >>> >>> >>> On 5/5/2019 10:03 AM, Heiner Kallweit wrote: So far we report symmetric pause only, and we don't consider the local pause capabilit

Re: [PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-05 Thread Florian Fainelli
On 5/5/2019 12:06 PM, Heiner Kallweit wrote: > On 05.05.2019 20:46, Florian Fainelli wrote: >> >> >> On 5/5/2019 10:31 AM, Heiner Kallweit wrote: >>> On 05.05.2019 19:10, Florian Fainelli wrote: On 5/5/2019 10:03 AM, Heiner Kallweit wrote: > So far we report symmetric pause on

Re: [PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-05 Thread Florian Fainelli
On 5/5/2019 10:31 AM, Heiner Kallweit wrote: > On 05.05.2019 19:10, Florian Fainelli wrote: >> >> >> On 5/5/2019 10:03 AM, Heiner Kallweit wrote: >>> So far we report symmetric pause only, and we don't consider the local >>> pause capabilities. Let's properly consider local and remote >>> capabi

Re: [PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-05 Thread Heiner Kallweit
On 05.05.2019 19:10, Florian Fainelli wrote: > > > On 5/5/2019 10:03 AM, Heiner Kallweit wrote: >> So far we report symmetric pause only, and we don't consider the local >> pause capabilities. Let's properly consider local and remote >> capabilities, and report also asymmetric pause. > > I would

Re: [PATCH net-next] net: phy: improve pause mode reporting in phy_print_status

2019-05-05 Thread Florian Fainelli
On 5/5/2019 10:03 AM, Heiner Kallweit wrote: > So far we report symmetric pause only, and we don't consider the local > pause capabilities. Let's properly consider local and remote > capabilities, and report also asymmetric pause. I would go one step further which is to print what is the link s