Re: [PATCH net-next] net: phy: improve handling link_change_notify callback

2019-04-04 Thread David Wu
Hi Heiner, Today i apply this patch, I test it on the RK3328 which has the phy, it looks good, and link state switching between 10M/100M is correct. 在 2019/3/21 上午1:50, David Miller 写道: From: Heiner Kallweit Date: Tue, 19 Mar 2019 19:56:51 +0100 Currently the Phy driver's link_change_notify

Re: [PATCH net-next] net: phy: improve handling link_change_notify callback

2019-03-20 Thread David Miller
From: Heiner Kallweit Date: Tue, 19 Mar 2019 19:56:51 +0100 > Currently the Phy driver's link_change_notify callback is called > whenever the state machine is run (every second if polling), no matter > whether the state changed or not. This isn't needed and may confuse > users considering the nam

Re: [PATCH net-next] net: phy: improve handling link_change_notify callback

2019-03-15 Thread David Wu
在 2019/3/13 上午1:50, Daniel Mack 写道: On 12/3/2019 1:27 PM, Heiko Stuebner wrote: Hi Andrew, Heiner, Am Montag, 4. März 2019, 21:06:30 CET schrieb Andrew Lunn: On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote: From: Heiner Kallweit Date: Sun, 3 Mar 2019 19:58:57 +0100 Currentl

Re: [PATCH net-next] net: phy: improve handling link_change_notify callback

2019-03-12 Thread Russell King - ARM Linux admin
On Tue, Mar 12, 2019 at 06:50:59PM +0100, Daniel Mack wrote: > On 12/3/2019 1:27 PM, Heiko Stuebner wrote: > > Hi Andrew, Heiner, > > > > Am Montag, 4. März 2019, 21:06:30 CET schrieb Andrew Lunn: > >> On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote: > >>> From: Heiner Kallweit > >>>

Re: [PATCH net-next] net: phy: improve handling link_change_notify callback

2019-03-12 Thread Daniel Mack
On 12/3/2019 1:27 PM, Heiko Stuebner wrote: > Hi Andrew, Heiner, > > Am Montag, 4. März 2019, 21:06:30 CET schrieb Andrew Lunn: >> On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote: >>> From: Heiner Kallweit >>> Date: Sun, 3 Mar 2019 19:58:57 +0100 >>> Currently the Phy driver's l

Re: [PATCH net-next] net: phy: improve handling link_change_notify callback

2019-03-12 Thread Florian Fainelli
On 3/3/19 10:58 AM, Heiner Kallweit wrote: > Currently the Phy driver's link_change_notify callback is called > whenever the state machine is run (every second if polling), no matter > whether the state changed or not. This isn't needed and may confuse > users considering the name of the callback.

Re: [PATCH net-next] net: phy: improve handling link_change_notify callback

2019-03-12 Thread Heiko Stuebner
Hi Andrew, Heiner, Am Montag, 4. März 2019, 21:06:30 CET schrieb Andrew Lunn: > On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote: > > From: Heiner Kallweit > > Date: Sun, 3 Mar 2019 19:58:57 +0100 > > > > > Currently the Phy driver's link_change_notify callback is called > > > whenev

Re: [PATCH net-next] net: phy: improve handling link_change_notify callback

2019-03-08 Thread David Miller
From: Heiner Kallweit Date: Sun, 3 Mar 2019 19:58:57 +0100 > Currently the Phy driver's link_change_notify callback is called > whenever the state machine is run (every second if polling), no matter > whether the state changed or not. This isn't needed and may confuse > users considering the name

Re: [PATCH net-next] net: phy: improve handling link_change_notify callback

2019-03-04 Thread David Miller
From: Andrew Lunn Date: Mon, 4 Mar 2019 21:06:30 +0100 > On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote: >> Someone please review this. > > We should probably wait for a Tested-by: from Daniel Mack > and David Wu , or > equivalent. Ok.

Re: [PATCH net-next] net: phy: improve handling link_change_notify callback

2019-03-04 Thread Andrew Lunn
On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote: > From: Heiner Kallweit > Date: Sun, 3 Mar 2019 19:58:57 +0100 > > > Currently the Phy driver's link_change_notify callback is called > > whenever the state machine is run (every second if polling), no matter > > whether the state chan

Re: [PATCH net-next] net: phy: improve handling link_change_notify callback

2019-03-04 Thread David Miller
From: Heiner Kallweit Date: Sun, 3 Mar 2019 19:58:57 +0100 > Currently the Phy driver's link_change_notify callback is called > whenever the state machine is run (every second if polling), no matter > whether the state changed or not. This isn't needed and may confuse > users considering the name