Re: [PATCH net-next] net: metrics: add proper netlink validation

2018-06-04 Thread Eric Dumazet
On 06/04/2018 04:46 PM, Eric Dumazet wrote: > Before using nla_get_u32(), better make sure the attribute > is of the proper size. > > > Fixes: a919525ad832 ("net: Move fib_convert_metrics to metrics file") > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Eric Dumazet > Reported-by

Re: [PATCH net-next] net: metrics: add proper netlink validation

2018-06-04 Thread Eric Dumazet
On 06/04/2018 04:54 PM, David Ahern wrote: > On 6/4/18 4:46 PM, Eric Dumazet wrote: >> Before using nla_get_u32(), better make sure the attribute >> is of the proper size. >> >> Code recently was changed, but bug has been there from beginning >> of git. >> > ... >> >> Fixes: a919525ad832 ("net:

Re: [PATCH net-next] net: metrics: add proper netlink validation

2018-06-04 Thread David Ahern
On 6/4/18 4:46 PM, Eric Dumazet wrote: > Before using nla_get_u32(), better make sure the attribute > is of the proper size. > > Code recently was changed, but bug has been there from beginning > of git. > ... > > Fixes: a919525ad832 ("net: Move fib_convert_metrics to metrics file") That commit