Re: [PATCH net-next] net: dsa: hellcreek: Offload bridge port flags

2021-03-16 Thread Kurt Kanzenbach
On Mon Mar 15 2021, Vladimir Oltean wrote: > On Mon, Mar 15, 2021 at 09:33:44PM +0100, Kurt Kanzenbach wrote: >> On Mon Mar 15 2021, Vladimir Oltean wrote: >> > On Sun, Mar 14, 2021 at 01:52:08PM +0100, Kurt Kanzenbach wrote: >> >> + if (enable) >> >> + val &= ~HR_PTCFG_UUC_FLT; >> >> + els

Re: [PATCH net-next] net: dsa: hellcreek: Offload bridge port flags

2021-03-15 Thread Vladimir Oltean
On Mon, Mar 15, 2021 at 09:33:44PM +0100, Kurt Kanzenbach wrote: > On Mon Mar 15 2021, Vladimir Oltean wrote: > > On Sun, Mar 14, 2021 at 01:52:08PM +0100, Kurt Kanzenbach wrote: > >> + if (enable) > >> + val &= ~HR_PTCFG_UUC_FLT; > >> + else > >> + val |= HR_PTCFG_UUC_FLT; > >

Re: [PATCH net-next] net: dsa: hellcreek: Offload bridge port flags

2021-03-15 Thread Kurt Kanzenbach
On Mon Mar 15 2021, Vladimir Oltean wrote: > On Sun, Mar 14, 2021 at 01:52:08PM +0100, Kurt Kanzenbach wrote: >> +if (enable) >> +val &= ~HR_PTCFG_UUC_FLT; >> +else >> +val |= HR_PTCFG_UUC_FLT; > > What does 'unknown unicast filtering' mean/do, exactly? > The semanti

Re: [PATCH net-next] net: dsa: hellcreek: Offload bridge port flags

2021-03-15 Thread Vladimir Oltean
On Sun, Mar 14, 2021 at 01:52:08PM +0100, Kurt Kanzenbach wrote: > The switch implements unicast and multicast filtering per port. > Add support for it. By default filtering is disabled. > > Signed-off-by: Kurt Kanzenbach > --- > drivers/net/dsa/hirschmann/hellcreek.c | 129 -

Re: [PATCH net-next] net: dsa: hellcreek: Offload bridge port flags

2021-03-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 14 Mar 2021 13:52:08 +0100 you wrote: > The switch implements unicast and multicast filtering per port. > Add support for it. By default filtering is disabled. > > Signed-off-by: Kurt Kanzenbach > --- > drivers/n

Re: [PATCH net-next] net: dsa: hellcreek: Offload bridge port flags

2021-03-14 Thread Leon Romanovsky
On Sun, Mar 14, 2021 at 01:52:08PM +0100, Kurt Kanzenbach wrote: > The switch implements unicast and multicast filtering per port. > Add support for it. By default filtering is disabled. > > Signed-off-by: Kurt Kanzenbach > --- > drivers/net/dsa/hirschmann/hellcreek.c | 129 --