Re: [PATCH net-next] net: don't include ethtool.h from netdevice.h

2020-11-20 Thread Shannon Nelson
On 11/20/20 2:13 PM, Jakub Kicinski wrote: linux/netdevice.h is included in very many places, touching any of its dependecies causes large incremental builds. Drop the linux/ethtool.h include, linux/netdevice.h just needs a forward declaration of struct ethtool_ops. Fix all the places which mad

Re: [PATCH net-next] net: don't include ethtool.h from netdevice.h

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 23:28:28 +0100 Johannes Berg wrote: > On Fri, 2020-11-20 at 14:13 -0800, Jakub Kicinski wrote: > > linux/netdevice.h is included in very many places, touching any > > of its dependecies causes large incremental builds. > > > > Drop the linux/ethtool.h include, linux/netdevice.h

Re: [PATCH net-next] net: don't include ethtool.h from netdevice.h

2020-11-20 Thread Johannes Berg
On Fri, 2020-11-20 at 14:13 -0800, Jakub Kicinski wrote: > linux/netdevice.h is included in very many places, touching any > of its dependecies causes large incremental builds. > > Drop the linux/ethtool.h include, linux/netdevice.h just needs > a forward declaration of struct ethtool_ops. > > Fi