Re: [PATCH net-next] mptcp: be careful on MPTCP-level ack.

2020-11-24 Thread Paolo Abeni
On Tue, 2020-11-24 at 10:08 -0800, Jakub Kicinski wrote: > On Tue, 24 Nov 2020 12:20:11 +0100 Paolo Abeni wrote: > > -static void mptcp_send_ack(struct mptcp_sock *msk, bool force) > > +static inline bool tcp_can_send_ack(const struct sock *ssk) > > +{ > > + return !((1 << inet_sk_state_load(ssk)

Re: [PATCH net-next] mptcp: be careful on MPTCP-level ack.

2020-11-24 Thread Jakub Kicinski
On Tue, 24 Nov 2020 12:20:11 +0100 Paolo Abeni wrote: > -static void mptcp_send_ack(struct mptcp_sock *msk, bool force) > +static inline bool tcp_can_send_ack(const struct sock *ssk) > +{ > + return !((1 << inet_sk_state_load(ssk)) & > +(TCPF_SYN_SENT | TCPF_SYN_RECV | TCPF_TIME_WAI