Re: [PATCH net-next] ipv6: Add icmp_echo_ignore_multicast support for ICMPv6

2019-03-19 Thread Eric Dumazet
On 03/19/2019 07:10 AM, Stephen Suryaputra wrote: > I wondered why NET_IPV6_ICMP_ECHO_IGNORE_ALL isn't being referenced. > Your comment made me probe further. Apparently, commit > e6f86b0f7ae473969a3301b74bf98af9e42ecd0e didn't add it to: > > static const struct bin_table bin_net_ipv6_icmp_tabl

Re: [PATCH net-next] ipv6: Add icmp_echo_ignore_multicast support for ICMPv6

2019-03-19 Thread Stephen Suryaputra
I wondered why NET_IPV6_ICMP_ECHO_IGNORE_ALL isn't being referenced. Your comment made me probe further. Apparently, commit e6f86b0f7ae473969a3301b74bf98af9e42ecd0e didn't add it to: static const struct bin_table bin_net_ipv6_icmp_table[] = { { CTL_INT, NET_IPV6_ICMP_RATELIMIT,"ratelimit

Re: [PATCH net-next] ipv6: Add icmp_echo_ignore_multicast support for ICMPv6

2019-03-19 Thread Eric Dumazet
On 03/19/2019 05:45 AM, Stephen Suryaputra wrote: > IPv4 has icmp_echo_ignore_broadcast to prevent responding to broadcast pings. > IPv6 needs a similar mechanism. > ... > diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h > index 87aa2a6d9125..bd83ddedc014 100644 > --- a

Re: [PATCH net-next] ipv6: Add icmp_echo_ignore_multicast support for ICMPv6

2019-03-11 Thread David Miller
net-next is closed, please resubmit this when net-next opens back up.