Re: [PATCH net-next,v2] IPv6 ifstats separation

2018-10-05 Thread Eric Dumazet
On 10/05/2018 06:00 AM, Stephen Suryaputra wrote: > On Thu, Oct 4, 2018 at 4:42 PM Eric Dumazet wrote: >> >> How have you decided some counters can be 'slow' and other 'fast' ? >> >> I can tell you I see many ultra-fast candidates in your 'slow' list :/ > > Based on what others have categorize

Re: [PATCH net-next,v2] IPv6 ifstats separation

2018-10-05 Thread Stephen Suryaputra
On Thu, Oct 4, 2018 at 4:42 PM Eric Dumazet wrote: > > How have you decided some counters can be 'slow' and other 'fast' ? > > I can tell you I see many ultra-fast candidates in your 'slow' list :/ Based on what others have categorized based on what's in the code and IMHO they make sense: enum {

Re: [PATCH net-next,v2] IPv6 ifstats separation

2018-10-04 Thread Eric Dumazet
On 10/04/2018 12:08 PM, Stephen Suryaputra wrote: > Separate IPv6 ifstats into the ones that are hit on fast path and > the ones that aren't. The ones that are not can be removed as needed > using sysctls. > > The separation minimizes percpu data. It reduces from 288 bytes per cpu to 56 > bytes