Re: [PATCH net] virtio_net: fix missing dma unmap for resize

2023-11-09 Thread Xuan Zhuo
On Fri, 10 Nov 2023 00:37:32 -0500, "Michael S. Tsirkin" wrote: > On Fri, Nov 10, 2023 at 09:58:45AM +0800, Xuan Zhuo wrote: > > On Thu, 9 Nov 2023 07:06:16 -0500, "Michael S. Tsirkin" > > wrote: > > > On Mon, Nov 06, 2023 at 04:18:32PM +0800, Xuan Zhuo wrote: > > > > For rq, we have three case

Re: [PATCH net] virtio_net: fix missing dma unmap for resize

2023-11-09 Thread Michael S. Tsirkin
On Fri, Nov 10, 2023 at 09:58:45AM +0800, Xuan Zhuo wrote: > On Thu, 9 Nov 2023 07:06:16 -0500, "Michael S. Tsirkin" > wrote: > > On Mon, Nov 06, 2023 at 04:18:32PM +0800, Xuan Zhuo wrote: > > > For rq, we have three cases getting buffers from virtio core: > > > > > > 1. virtqueue_get_buf{,_ctx}

Re: [PATCH net] virtio_net: fix missing dma unmap for resize

2023-11-09 Thread Xuan Zhuo
On Thu, 9 Nov 2023 07:06:16 -0500, "Michael S. Tsirkin" wrote: > On Mon, Nov 06, 2023 at 04:18:32PM +0800, Xuan Zhuo wrote: > > For rq, we have three cases getting buffers from virtio core: > > > > 1. virtqueue_get_buf{,_ctx} > > 2. virtqueue_detach_unused_buf > > 3. callback for virtqueue_resize

Re: [PATCH net] virtio_net: fix missing dma unmap for resize

2023-11-09 Thread Michael S. Tsirkin
On Mon, Nov 06, 2023 at 04:18:32PM +0800, Xuan Zhuo wrote: > For rq, we have three cases getting buffers from virtio core: > > 1. virtqueue_get_buf{,_ctx} > 2. virtqueue_detach_unused_buf > 3. callback for virtqueue_resize > > But in commit 295525e29a5b("virtio_net: merge dma operations when > fi

Re: [PATCH net] virtio_net: fix missing dma unmap for resize

2023-11-09 Thread Paolo Abeni
On Mon, 2023-11-06 at 16:18 +0800, Xuan Zhuo wrote: > For rq, we have three cases getting buffers from virtio core: > > 1. virtqueue_get_buf{,_ctx} > 2. virtqueue_detach_unused_buf > 3. callback for virtqueue_resize > > But in commit 295525e29a5b("virtio_net: merge dma operations when > filling m