Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-10 Thread Xuan Zhuo
On Tue, 10 Sep 2024 14:18:37 +0800, Jason Wang wrote: > On Mon, Sep 9, 2024 at 4:50 PM Xuan Zhuo wrote: > > > > On Mon, 9 Sep 2024 16:38:16 +0800, Jason Wang wrote: > > > On Fri, Sep 6, 2024 at 5:32 PM Xuan Zhuo > > > wrote: > > > > > > > > On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsirki

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-09 Thread Jason Wang
On Mon, Sep 9, 2024 at 4:50 PM Xuan Zhuo wrote: > > On Mon, 9 Sep 2024 16:38:16 +0800, Jason Wang wrote: > > On Fri, Sep 6, 2024 at 5:32 PM Xuan Zhuo wrote: > > > > > > On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Fri, Sep 06, 2024 at 04:53:38PM +0800, Xuan Z

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-09 Thread Jason Wang
On Mon, Sep 9, 2024 at 4:52 PM Xuan Zhuo wrote: > > On Mon, 9 Sep 2024 16:47:02 +0800, Jason Wang wrote: > > On Mon, Sep 9, 2024 at 11:16 AM Xuan Zhuo > > wrote: > > > > > > On Sun, 8 Sep 2024 15:40:32 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Tue, Aug 20, 2024 at 03:19:13PM +0800,

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-09 Thread Darren Kenny
Hi, Apologies, I've been OOTO for the best part of 2 weeks, I'll try get to this as soon as I can, but playing catch-up right now. Thanks, Darren. On Saturday, 2024-09-07 at 12:16:24 +09, Takero Funaki wrote: > 2024年9月6日(金) 18:55 Michael S. Tsirkin : >> >> On Fri, Sep 06, 2024 at 05:46:02PM +08

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-09 Thread Xuan Zhuo
On Mon, 9 Sep 2024 16:47:02 +0800, Jason Wang wrote: > On Mon, Sep 9, 2024 at 11:16 AM Xuan Zhuo wrote: > > > > On Sun, 8 Sep 2024 15:40:32 -0400, "Michael S. Tsirkin" > > wrote: > > > On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > > > > leads to regression on VM with the sysctl v

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-09 Thread Xuan Zhuo
On Mon, 9 Sep 2024 16:38:16 +0800, Jason Wang wrote: > On Fri, Sep 6, 2024 at 5:32 PM Xuan Zhuo wrote: > > > > On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsirkin" > > wrote: > > > On Fri, Sep 06, 2024 at 04:53:38PM +0800, Xuan Zhuo wrote: > > > > On Fri, 6 Sep 2024 04:43:29 -0400, "Michael

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-09 Thread Jason Wang
On Mon, Sep 9, 2024 at 11:16 AM Xuan Zhuo wrote: > > On Sun, 8 Sep 2024 15:40:32 -0400, "Michael S. Tsirkin" > wrote: > > On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > > > leads to regression on VM with the sysctl value of: > > > > > > - net.core.high_order_alloc_disable=1 > > > >

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-09 Thread Jason Wang
On Fri, Sep 6, 2024 at 5:32 PM Xuan Zhuo wrote: > > On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsirkin" > wrote: > > On Fri, Sep 06, 2024 at 04:53:38PM +0800, Xuan Zhuo wrote: > > > On Fri, 6 Sep 2024 04:43:29 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Tue, Aug 20, 2024 at 03:19:1

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-08 Thread Xuan Zhuo
On Sun, 8 Sep 2024 15:40:32 -0400, "Michael S. Tsirkin" wrote: > On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > > leads to regression on VM with the sysctl value of: > > > > - net.core.high_order_alloc_disable=1 > > > > which could see reliable crashes or scp failure (scp a file 100M

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-08 Thread Michael S. Tsirkin
On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > leads to regression on VM with the sysctl value of: > > - net.core.high_order_alloc_disable=1 > > which could see reliable crashes or scp failure (scp a file 100M in size > to VM): > > The issue is that the virtnet_rq_dma takes up 16 b

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-08 Thread Takero Funaki
2024年9月8日(日) 19:19 Michael S. Tsirkin : > > On Sat, Sep 07, 2024 at 12:16:24PM +0900, Takero Funaki wrote: > > 2024年9月6日(金) 18:55 Michael S. Tsirkin : > > > > > > On Fri, Sep 06, 2024 at 05:46:02PM +0800, Xuan Zhuo wrote: > > > > On Fri, 6 Sep 2024 05:44:27 -0400, "Michael S. Tsirkin" > > > > wro

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-08 Thread Michael S. Tsirkin
On Sat, Sep 07, 2024 at 12:16:24PM +0900, Takero Funaki wrote: > 2024年9月6日(金) 18:55 Michael S. Tsirkin : > > > > On Fri, Sep 06, 2024 at 05:46:02PM +0800, Xuan Zhuo wrote: > > > On Fri, 6 Sep 2024 05:44:27 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Fri, Sep 06, 2024 at 05:25:36PM +0800,

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Takero Funaki
2024年9月6日(金) 18:55 Michael S. Tsirkin : > > On Fri, Sep 06, 2024 at 05:46:02PM +0800, Xuan Zhuo wrote: > > On Fri, 6 Sep 2024 05:44:27 -0400, "Michael S. Tsirkin" > > wrote: > > > On Fri, Sep 06, 2024 at 05:25:36PM +0800, Xuan Zhuo wrote: > > > > On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsi

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Michael S. Tsirkin
On Fri, Sep 06, 2024 at 05:46:02PM +0800, Xuan Zhuo wrote: > On Fri, 6 Sep 2024 05:44:27 -0400, "Michael S. Tsirkin" > wrote: > > On Fri, Sep 06, 2024 at 05:25:36PM +0800, Xuan Zhuo wrote: > > > On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Fri, Sep 06, 2024 at

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Xuan Zhuo
On Fri, 6 Sep 2024 05:44:27 -0400, "Michael S. Tsirkin" wrote: > On Fri, Sep 06, 2024 at 05:25:36PM +0800, Xuan Zhuo wrote: > > On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsirkin" > > wrote: > > > On Fri, Sep 06, 2024 at 04:53:38PM +0800, Xuan Zhuo wrote: > > > > On Fri, 6 Sep 2024 04:43:29

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Michael S. Tsirkin
On Fri, Sep 06, 2024 at 05:25:36PM +0800, Xuan Zhuo wrote: > On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsirkin" > wrote: > > On Fri, Sep 06, 2024 at 04:53:38PM +0800, Xuan Zhuo wrote: > > > On Fri, 6 Sep 2024 04:43:29 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Tue, Aug 20, 2024 at

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Xuan Zhuo
On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsirkin" wrote: > On Fri, Sep 06, 2024 at 04:53:38PM +0800, Xuan Zhuo wrote: > > On Fri, 6 Sep 2024 04:43:29 -0400, "Michael S. Tsirkin" > > wrote: > > > On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > > > > leads to regression on VM wi

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Michael S. Tsirkin
On Fri, Sep 06, 2024 at 04:53:38PM +0800, Xuan Zhuo wrote: > On Fri, 6 Sep 2024 04:43:29 -0400, "Michael S. Tsirkin" > wrote: > > On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > > > leads to regression on VM with the sysctl value of: > > > > > > - net.core.high_order_alloc_disable=1

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Xuan Zhuo
On Fri, 6 Sep 2024 04:43:29 -0400, "Michael S. Tsirkin" wrote: > On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > > leads to regression on VM with the sysctl value of: > > > > - net.core.high_order_alloc_disable=1 > > > > which could see reliable crashes or scp failure (scp a file 100M

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Michael S. Tsirkin
On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > leads to regression on VM with the sysctl value of: > > - net.core.high_order_alloc_disable=1 > > which could see reliable crashes or scp failure (scp a file 100M in size > to VM): > > The issue is that the virtnet_rq_dma takes up 16 b

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-29 Thread Xuan Zhuo
On Wed, 21 Aug 2024 17:47:06 +0100, Darren Kenny wrote: > > Hi Michael, > > On Tuesday, 2024-08-20 at 12:50:39 -04, Michael S. Tsirkin wrote: > > On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > >> leads to regression on VM with the sysctl value of: > >> > >> - net.core.high_order_all

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-29 Thread Michael S. Tsirkin
On Thu, Aug 29, 2024 at 03:38:07PM +0800, Xuan Zhuo wrote: > On Thu, 29 Aug 2024 03:35:58 -0400, "Michael S. Tsirkin" > wrote: > > On Thu, Aug 29, 2024 at 03:26:00PM +0800, Xuan Zhuo wrote: > > > On Thu, 29 Aug 2024 12:51:31 +0800, Jason Wang > > > wrote: > > > > On Wed, Aug 28, 2024 at 7:21 PM

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-29 Thread Xuan Zhuo
On Thu, 29 Aug 2024 03:35:58 -0400, "Michael S. Tsirkin" wrote: > On Thu, Aug 29, 2024 at 03:26:00PM +0800, Xuan Zhuo wrote: > > On Thu, 29 Aug 2024 12:51:31 +0800, Jason Wang wrote: > > > On Wed, Aug 28, 2024 at 7:21 PM Xuan Zhuo > > > wrote: > > > > > > > > On Tue, 27 Aug 2024 11:38:45 +0800

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-29 Thread Michael S. Tsirkin
On Thu, Aug 29, 2024 at 03:26:00PM +0800, Xuan Zhuo wrote: > On Thu, 29 Aug 2024 12:51:31 +0800, Jason Wang wrote: > > On Wed, Aug 28, 2024 at 7:21 PM Xuan Zhuo > > wrote: > > > > > > On Tue, 27 Aug 2024 11:38:45 +0800, Jason Wang > > > wrote: > > > > On Tue, Aug 20, 2024 at 3:19 PM Xuan Zhuo

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-29 Thread Xuan Zhuo
On Thu, 29 Aug 2024 12:51:31 +0800, Jason Wang wrote: > On Wed, Aug 28, 2024 at 7:21 PM Xuan Zhuo wrote: > > > > On Tue, 27 Aug 2024 11:38:45 +0800, Jason Wang wrote: > > > On Tue, Aug 20, 2024 at 3:19 PM Xuan Zhuo > > > wrote: > > > > > > > > leads to regression on VM with the sysctl value of

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-28 Thread Xuan Zhuo
On Thu, 29 Aug 2024 12:51:31 +0800, Jason Wang wrote: > On Wed, Aug 28, 2024 at 7:21 PM Xuan Zhuo wrote: > > > > On Tue, 27 Aug 2024 11:38:45 +0800, Jason Wang wrote: > > > On Tue, Aug 20, 2024 at 3:19 PM Xuan Zhuo > > > wrote: > > > > > > > > leads to regression on VM with the sysctl value of

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-28 Thread Xuan Zhuo
On Wed, 28 Aug 2024 12:57:56 -0700, "Si-Wei Liu" wrote: > Just in case Xuan missed the last email while his email server kept > rejecting incoming emails in the last week.: the patch doesn't seem fix > the regression. > > Xuan, given this is not very hard to reproduce and we have clearly > stated

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-28 Thread Jason Wang
On Wed, Aug 28, 2024 at 7:21 PM Xuan Zhuo wrote: > > On Tue, 27 Aug 2024 11:38:45 +0800, Jason Wang wrote: > > On Tue, Aug 20, 2024 at 3:19 PM Xuan Zhuo > > wrote: > > > > > > leads to regression on VM with the sysctl value of: > > > > > > - net.core.high_order_alloc_disable=1 > > > > > > which

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-28 Thread Si-Wei Liu
Just in case Xuan missed the last email while his email server kept rejecting incoming emails in the last week.: the patch doesn't seem fix the regression. Xuan, given this is not very hard to reproduce and we have clearly stated how to, could you try to get the patch verified in house before

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-28 Thread Xuan Zhuo
On Tue, 27 Aug 2024 11:38:45 +0800, Jason Wang wrote: > On Tue, Aug 20, 2024 at 3:19 PM Xuan Zhuo wrote: > > > > leads to regression on VM with the sysctl value of: > > > > - net.core.high_order_alloc_disable=1 > > > > which could see reliable crashes or scp failure (scp a file 100M in size > > t

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-26 Thread Jason Wang
On Tue, Aug 20, 2024 at 3:19 PM Xuan Zhuo wrote: > > leads to regression on VM with the sysctl value of: > > - net.core.high_order_alloc_disable=1 > > which could see reliable crashes or scp failure (scp a file 100M in size > to VM): > > The issue is that the virtnet_rq_dma takes up 16 bytes at th

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-21 Thread Darren Kenny
Hi Michael, On Tuesday, 2024-08-20 at 12:50:39 -04, Michael S. Tsirkin wrote: > On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: >> leads to regression on VM with the sysctl value of: >> >> - net.core.high_order_alloc_disable=1 > > > > >> which could see reliable crashes or scp failur

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-20 Thread Si-Wei Liu
On 8/20/2024 1:09 PM, Michael S. Tsirkin wrote: On Tue, Aug 20, 2024 at 12:44:46PM -0700, Si-Wei Liu wrote: On 8/20/2024 12:19 AM, Xuan Zhuo wrote: leads to regression on VM with the sysctl value of: - net.core.high_order_alloc_disable=1 which could see reliable crashes or scp failure (sc

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-20 Thread Michael S. Tsirkin
On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > leads to regression on VM with the sysctl value of: > > - net.core.high_order_alloc_disable=1 > > which could see reliable crashes or scp failure (scp a file 100M in size > to VM): > > The issue is that the virtnet_rq_dma takes up 16 b

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-20 Thread Michael S. Tsirkin
On Tue, Aug 20, 2024 at 12:44:46PM -0700, Si-Wei Liu wrote: > > > On 8/20/2024 12:19 AM, Xuan Zhuo wrote: > > leads to regression on VM with the sysctl value of: > > > > - net.core.high_order_alloc_disable=1 > > > > which could see reliable crashes or scp failure (scp a file 100M in size > > to

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-20 Thread Si-Wei Liu
On 8/20/2024 12:19 AM, Xuan Zhuo wrote: leads to regression on VM with the sysctl value of: - net.core.high_order_alloc_disable=1 which could see reliable crashes or scp failure (scp a file 100M in size to VM): The issue is that the virtnet_rq_dma takes up 16 bytes at the beginning of a new

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-20 Thread Michael S. Tsirkin
On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > leads to regression on VM with the sysctl value of: > > - net.core.high_order_alloc_disable=1 > which could see reliable crashes or scp failure (scp a file 100M in size > to VM): > > The issue is that the virtnet_rq_dma takes up 16

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-08-20 Thread Alexander Lobakin
From: Xuan Zhuo Date: Tue, 20 Aug 2024 15:19:13 +0800 > leads to regression on VM with the sysctl value of: Where's the beginning of the sentence? You mean, "This overflow leads"? > > - net.core.high_order_alloc_disable=1 This `- ` can be removed - at least some syntax highlighters color it i