Re: [PATCH net] tcp: ulp: fix possible crash in tcp_diag_get_aux_size()

2019-09-07 Thread David Miller
From: Eric Dumazet Date: Thu, 5 Sep 2019 13:20:41 -0700 > tcp_diag_get_aux_size() can be called with sockets in any state. > > icsk_ulp_ops is only present for full sockets. > > For SYN_RECV or TIME_WAIT ones we would access garbage. > > Fixes: 61723b393292 ("tcp: ulp: add functions to dump u

Re: [PATCH net] tcp: ulp: fix possible crash in tcp_diag_get_aux_size()

2019-09-06 Thread Davide Caratti
On Thu, 2019-09-05 at 13:20 -0700, Eric Dumazet wrote: > tcp_diag_get_aux_size() can be called with sockets in any state. > > icsk_ulp_ops is only present for full sockets. > > For SYN_RECV or TIME_WAIT ones we would access garbage. > hello Eric, thanks for fixing this! Acked-by: Davide Cara

Re: [PATCH net] tcp: ulp: fix possible crash in tcp_diag_get_aux_size()

2019-09-05 Thread Eric Dumazet
On Thu, Sep 5, 2019 at 10:20 PM Eric Dumazet wrote: > > tcp_diag_get_aux_size() can be called with sockets in any state. > > icsk_ulp_ops is only present for full sockets. > > For SYN_RECV or TIME_WAIT ones we would access garbage. > > Fixes: 61723b393292 ("tcp: ulp: add functions to dump ulp-spec