Re: [PATCH net] tcp: fix tcp_inet6_sk() for 32bit kernels

2019-04-01 Thread Julian Anastasov
Hello, On Mon, 1 Apr 2019, Eric Dumazet wrote: > It turns out that struct ipv6_pinfo is not located as we think. > > inet6_sk_generic() and tcp_inet6_sk() disagree on 32bit kernels by 4-bytes, > because struct tcp_sock has 8-bytes alignment, > but ipv6_pinfo size is not a multiple of 8

Re: [PATCH net] tcp: fix tcp_inet6_sk() for 32bit kernels

2019-04-01 Thread Eric Dumazet
On Mon, Apr 1, 2019 at 10:22 AM David Miller wrote: > > > This looks like a net-next change, because the Fixes tag commit is only > there. So that's where I have applied it. Oops, wrong script, yes this is a net-next change. > > Maybe we should change the name of the tcp6_sock.inet6 member if i

Re: [PATCH net] tcp: fix tcp_inet6_sk() for 32bit kernels

2019-04-01 Thread David Miller
From: Eric Dumazet Date: Mon, 1 Apr 2019 03:09:20 -0700 > It turns out that struct ipv6_pinfo is not located as we think. > > inet6_sk_generic() and tcp_inet6_sk() disagree on 32bit kernels by 4-bytes, > because struct tcp_sock has 8-bytes alignment, > but ipv6_pinfo size is not a multiple of 8