Re: [PATCH net] tcp: Fix SOF_TIMESTAMPING_TX_ACK when handling dup acks

2016-04-21 Thread David Miller
From: Martin KaFai Lau Date: Mon, 18 Apr 2016 15:39:53 -0700 > Assuming SOF_TIMESTAMPING_TX_ACK is on. When dup acks are received, > it could incorrectly think that a skb has already > been acked and queue a SCM_TSTAMP_ACK cmsg to the > sk->sk_error_queue. > > In tcp_ack_tstamp(), it checks > 'b

Re: [PATCH net] tcp: Fix SOF_TIMESTAMPING_TX_ACK when handling dup acks

2016-04-20 Thread Soheil Hassas Yeganeh
On Tue, Apr 19, 2016 at 9:54 AM, Soheil Hassas Yeganeh wrote: > On Mon, Apr 18, 2016 at 6:39 PM, Martin KaFai Lau wrote: >> Assuming SOF_TIMESTAMPING_TX_ACK is on. When dup acks are received, >> it could incorrectly think that a skb has already >> been acked and queue a SCM_TSTAMP_ACK cmsg to the

Re: [PATCH net] tcp: Fix SOF_TIMESTAMPING_TX_ACK when handling dup acks

2016-04-19 Thread Soheil Hassas Yeganeh
On Mon, Apr 18, 2016 at 6:39 PM, Martin KaFai Lau wrote: > Assuming SOF_TIMESTAMPING_TX_ACK is on. When dup acks are received, > it could incorrectly think that a skb has already > been acked and queue a SCM_TSTAMP_ACK cmsg to the > sk->sk_error_queue. > > In tcp_ack_tstamp(), it checks > 'between