Re: [PATCH net] sctp: check duplicate node before inserting a new transport

2017-02-19 Thread David Miller
From: Xin Long Date: Fri, 17 Feb 2017 16:35:24 +0800 > sctp has changed to use rhlist for transport rhashtable since commit > 7fda702f9315 ("sctp: use new rhlist interface on sctp transport > rhashtable"). > > But rhltable_insert_key doesn't check the duplicate node when inserting > a node, unli

Re: [PATCH net] sctp: check duplicate node before inserting a new transport

2017-02-18 Thread Xin Long
On Sat, Feb 18, 2017 at 4:19 AM, David Miller wrote: > From: Xin Long > Date: Fri, 17 Feb 2017 16:35:24 +0800 > > >> + list = rhltable_lookup(&sctp_transport_hashtable, &arg, >> +sctp_hash_params); >> + >> + rhl_for_each_entry_rcu(transport, tmp, list, node) >>

Re: [PATCH net] sctp: check duplicate node before inserting a new transport

2017-02-17 Thread David Miller
From: Xin Long Date: Fri, 17 Feb 2017 16:35:24 +0800 > + list = rhltable_lookup(&sctp_transport_hashtable, &arg, > +sctp_hash_params); > + > + rhl_for_each_entry_rcu(transport, tmp, list, node) > + if (transport->asoc->ep == t->asoc->ep) { > +

Re: [PATCH net] sctp: check duplicate node before inserting a new transport

2017-02-17 Thread Xin Long
On Fri, Feb 17, 2017 at 7:19 PM, Neil Horman wrote: > On Fri, Feb 17, 2017 at 04:35:24PM +0800, Xin Long wrote: >> sctp has changed to use rhlist for transport rhashtable since commit >> 7fda702f9315 ("sctp: use new rhlist interface on sctp transport >> rhashtable"). >> >> But rhltable_insert_key

Re: [PATCH net] sctp: check duplicate node before inserting a new transport

2017-02-17 Thread Neil Horman
On Fri, Feb 17, 2017 at 04:35:24PM +0800, Xin Long wrote: > sctp has changed to use rhlist for transport rhashtable since commit > 7fda702f9315 ("sctp: use new rhlist interface on sctp transport > rhashtable"). > > But rhltable_insert_key doesn't check the duplicate node when inserting > a node, u