Re: [PATCH net] netdevsim: fix unbalaced locking in nsim_create()

2020-07-20 Thread Taehee Yoo
On Tue, 21 Jul 2020 at 02:57, Jakub Kicinski wrote: > Hi Jakub, Thank you for your review! > On Sat, 18 Jul 2020 06:49:21 + Taehee Yoo wrote: > > In the nsim_create(), rtnl_lock() is called before nsim_bpf_init(). > > If nsim_bpf_init() is failed, rtnl_unlock() should be called, > > but it i

Re: [PATCH net] netdevsim: fix unbalaced locking in nsim_create()

2020-07-20 Thread Jakub Kicinski
On Sat, 18 Jul 2020 06:49:21 + Taehee Yoo wrote: > In the nsim_create(), rtnl_lock() is called before nsim_bpf_init(). > If nsim_bpf_init() is failed, rtnl_unlock() should be called, > but it isn't called. > So, unbalanced locking would occur. > > Fixes: e05b2d141fef ("netdevsim: move netdev c