Re: [PATCH net] net: vrf: fix remove vrf module error when there's no reference

2019-03-04 Thread kbuild test robot
Hi Miaohe, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/linmiaohe/net-vrf-fix-remove-vrf-module-error-when-there-s-no-reference/20190303-082433 config: x86_64-randconfig-u0-03041013 (attached as .

Re: [PATCH net] net: vrf: fix remove vrf module error when there's no reference

2019-03-03 Thread linmiaohe
On 2019/3/3 4:15, David Ahern wrote: > On 3/2/19 5:31 AM, linmiaohe wrote: >> From: Miaohe Lin >> >> If we insmod vrf.ko, there is no way to remove it because of lack of >> module_exit. >> I think we may need it. >> >> Signed-off-by: Miaohe Lin >> --- >> drivers/net/vrf.c | 8 >> 1 fil

Re: [PATCH net] net: vrf: fix remove vrf module error when there's no reference

2019-03-02 Thread David Ahern
On 3/2/19 5:31 AM, linmiaohe wrote: > From: Miaohe Lin > > If we insmod vrf.ko, there is no way to remove it because of lack of > module_exit. > I think we may need it. > > Signed-off-by: Miaohe Lin > --- > drivers/net/vrf.c | 8 > 1 file changed, 8 insertions(+) The ability to unlo