Re: [PATCH net] net: netem: fix error path for corrupted GSO frames

2019-10-17 Thread Cong Wang
On Thu, Oct 17, 2019 at 11:44 AM Jakub Kicinski wrote: > > On Thu, 17 Oct 2019 11:10:06 -0700, Cong Wang wrote: > > On Wed, Oct 16, 2019 at 4:22 PM Jakub Kicinski wrote: > > > On Wed, 16 Oct 2019 15:42:28 -0700, Cong Wang wrote: > > > > > @@ -612,7 +613,7 @@ static int netem_enqueue(struct sk_buff

Re: [PATCH net] net: netem: fix error path for corrupted GSO frames

2019-10-17 Thread Jakub Kicinski
On Thu, 17 Oct 2019 11:10:06 -0700, Cong Wang wrote: > On Wed, Oct 16, 2019 at 4:22 PM Jakub Kicinski wrote: > > On Wed, 16 Oct 2019 15:42:28 -0700, Cong Wang wrote: > > > > @@ -612,7 +613,7 @@ static int netem_enqueue(struct sk_buff *skb, > > > > struct Qdisc *sch, > > > >

Re: [PATCH net] net: netem: fix error path for corrupted GSO frames

2019-10-17 Thread Cong Wang
On Wed, Oct 16, 2019 at 4:22 PM Jakub Kicinski wrote: > > On Wed, 16 Oct 2019 15:42:28 -0700, Cong Wang wrote: > > > @@ -612,7 +613,7 @@ static int netem_enqueue(struct sk_buff *skb, struct > > > Qdisc *sch, > > > } > > > segs = skb2; > > >

Re: [PATCH net] net: netem: fix error path for corrupted GSO frames

2019-10-16 Thread Jakub Kicinski
On Wed, 16 Oct 2019 15:42:28 -0700, Cong Wang wrote: > > @@ -612,7 +613,7 @@ static int netem_enqueue(struct sk_buff *skb, struct > > Qdisc *sch, > > } > > segs = skb2; > > } > > - qdisc_tree_reduce_backlog(sch, -nb, pre

Re: [PATCH net] net: netem: fix error path for corrupted GSO frames

2019-10-16 Thread Cong Wang
On Wed, Oct 16, 2019 at 3:23 PM Jakub Kicinski wrote: > > To corrupt a GSO frame we first perform segmentation. We then > proceed using the first segment instead of the full GSO skb and > requeue the rest of the segments as separate packets. > > If there are any issues with processing the first s