Re: [PATCH net] net: dsa: don't assign an error value to tag_ops

2021-03-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 22 Mar 2021 15:26:50 -0500 you wrote: > Use a temporary variable to hold the return value from > dsa_tag_driver_get() instead of assigning it to dst->tag_ops. Leaving > an error value in dst->tag_ops can result in defere

Re: [PATCH net] net: dsa: don't assign an error value to tag_ops

2021-03-22 Thread Florian Fainelli
On 3/22/2021 1:26 PM, George McCollister wrote: > Use a temporary variable to hold the return value from > dsa_tag_driver_get() instead of assigning it to dst->tag_ops. Leaving > an error value in dst->tag_ops can result in deferencing an invalid > pointer when a deferred switch configuration ha

Re: [PATCH net] net: dsa: don't assign an error value to tag_ops

2021-03-22 Thread Vladimir Oltean
On Mon, Mar 22, 2021 at 03:26:50PM -0500, George McCollister wrote: > Use a temporary variable to hold the return value from > dsa_tag_driver_get() instead of assigning it to dst->tag_ops. Leaving > an error value in dst->tag_ops can result in deferencing an invalid > pointer when a deferred switch

Re: [PATCH net] net: dsa: don't assign an error value to tag_ops

2021-03-22 Thread George McCollister
On Mon, Mar 22, 2021 at 3:46 PM Vladimir Oltean wrote: > > On Mon, Mar 22, 2021 at 03:26:50PM -0500, George McCollister wrote: > > Use a temporary variable to hold the return value from > > dsa_tag_driver_get() instead of assigning it to dst->tag_ops. Leaving > > an error value in dst->tag_ops can

Re: [PATCH net] net: dsa: don't assign an error value to tag_ops

2021-03-22 Thread Vladimir Oltean
On Mon, Mar 22, 2021 at 03:26:50PM -0500, George McCollister wrote: > Use a temporary variable to hold the return value from > dsa_tag_driver_get() instead of assigning it to dst->tag_ops. Leaving > an error value in dst->tag_ops can result in deferencing an invalid > pointer when a deferred switch