Re: [PATCH net] mld: fix panic in mld_newpack()

2020-12-27 Thread Taehee Yoo
On Mon, 28 Dec 2020 at 04:24, Cong Wang wrote: > > On Sun, Dec 27, 2020 at 6:40 AM Taehee Yoo wrote: > > But I'm so sorry I didn't understand some points. > > > > 1. you said "both side" and I understand these as follows: > > a) failure of allocation because of a high order and it is fixed > > by

Re: [PATCH net] mld: fix panic in mld_newpack()

2020-12-27 Thread Cong Wang
On Sun, Dec 27, 2020 at 6:40 AM Taehee Yoo wrote: > But I'm so sorry I didn't understand some points. > > 1. you said "both side" and I understand these as follows: > a) failure of allocation because of a high order and it is fixed > by 72e09ad107e7 > b) kernel panic because of 72e09ad107e7 > Are

Re: [PATCH net] mld: fix panic in mld_newpack()

2020-12-27 Thread Taehee Yoo
On Sun, 27 Dec 2020 at 04:27, Cong Wang wrote: > Hi Cong, Thank you so much for the review! > On Wed, Dec 23, 2020 at 8:55 AM Taehee Yoo wrote: > > > > mld_newpack() doesn't allow to allocate high order page, > > just order-0 allocation is allowed. > > If headroom size is too large, a kernel pa

Re: [PATCH net] mld: fix panic in mld_newpack()

2020-12-26 Thread Cong Wang
On Wed, Dec 23, 2020 at 8:55 AM Taehee Yoo wrote: > > mld_newpack() doesn't allow to allocate high order page, > just order-0 allocation is allowed. > If headroom size is too large, a kernel panic could occur in skb_put(). ... > Allowing high order page allocation could fix this problem. > > Fixes