Re: [PATCH net] ibmveth: use net_err_ratelimited when set_multicast_list

2019-08-02 Thread Hangbin Liu
On Thu, Aug 01, 2019 at 12:51:14PM -0400, David Miller wrote: > From: Hangbin Liu > Date: Thu, 1 Aug 2019 17:03:47 +0800 > > > When setting lots of multicast list on ibmveth, e.g. add 3000 membership on > > a > > multicast group, the following error message flushes our log file > > > > 8507

Re: [PATCH net] ibmveth: use net_err_ratelimited when set_multicast_list

2019-08-01 Thread Joe Perches
On Thu, 2019-08-01 at 12:51 -0400, David Miller wrote: > From: Hangbin Liu > Date: Thu, 1 Aug 2019 17:03:47 +0800 > > > When setting lots of multicast list on ibmveth, e.g. add 3000 membership on > > a > > multicast group, the following error message flushes our log file > > > > 8507[ 901

Re: [PATCH net] ibmveth: use net_err_ratelimited when set_multicast_list

2019-08-01 Thread Joe Perches
On Thu, 2019-08-01 at 22:10 +0800, Hangbin Liu wrote: > On Thu, Aug 01, 2019 at 03:28:43AM -0700, Joe Perches wrote: > > Perhaps add the netdev__ratelimited variants and use that instead > > > > Somthing like: > > Yes, that looks better. Do you mind if I take your code and add your > Signed-off-b

Re: [PATCH net] ibmveth: use net_err_ratelimited when set_multicast_list

2019-08-01 Thread David Miller
From: Hangbin Liu Date: Thu, 1 Aug 2019 17:03:47 +0800 > When setting lots of multicast list on ibmveth, e.g. add 3000 membership on a > multicast group, the following error message flushes our log file > > 8507[ 901.478251] ibmveth 3003 env3: h_multicast_ctrl rc=4 when > adding an en

Re: [PATCH net] ibmveth: use net_err_ratelimited when set_multicast_list

2019-08-01 Thread Hangbin Liu
On Thu, Aug 01, 2019 at 03:28:43AM -0700, Joe Perches wrote: > Perhaps add the netdev__ratelimited variants and use that instead > > Somthing like: Yes, that looks better. Do you mind if I take your code and add your Signed-off-by info? Thanks Hangbin > > --- > include/linux/netdevice.h | 54

Re: [PATCH net] ibmveth: use net_err_ratelimited when set_multicast_list

2019-08-01 Thread Joe Perches
On Thu, 2019-08-01 at 17:03 +0800, Hangbin Liu wrote: > When setting lots of multicast list on ibmveth, e.g. add 3000 membership on a > multicast group, the following error message flushes our log file > > 8507[ 901.478251] ibmveth 3003 env3: h_multicast_ctrl rc=4 when > adding an entry