Re: [PATCH net] cxgb4: Fix panic when attaching to ULD fails

2019-10-16 Thread David Miller
From: Vishal Kulkarni Date: Mon, 14 Oct 2019 13:20:35 +0530 > @@ -760,7 +762,9 @@ void cxgb4_register_uld(enum cxgb4_uld type, > if (ret) > goto free_irq; > adap->uld[type] = *p; > - uld_attach(adap, type); > + ret = uld_at

Re: [PATCH net] cxgb4: Fix panic when attaching to ULD fails

2019-10-14 Thread Simon Horman
On Mon, Oct 14, 2019 at 01:20:35PM +0530, Vishal Kulkarni wrote: > Release resources when attaching to ULD fail. Otherwise, data > mismatch is seen between LLD and ULD later on, which lead to > kernel panic when accessing resources that should not even > exist in the first place. > > Fixes: 94cdb8