Re: [PATCH net] can: peak_usb: add range checking in decode operations

2020-10-26 Thread Marc Kleine-Budde
On 10/26/20 2:28 PM, Stéphane Grosjean wrote: > ​​Hello Dan, > > You have my Ack. > > Acked-by: Stephane Grosjean Applied to linux-can/testing. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertr

RE: [PATCH net] can: peak_usb: add range checking in decode operations

2020-10-26 Thread Stéphane Grosjean
​​Hello Dan, You have my Ack. Acked-by: Stephane Grosjean --- Stéphane Grosjean PEAK-System France 132, rue André Bisiaux F-54320 MAXEVILLE Tél : +(33) 9.72.54.51.97 De : Dan Carpenter Envoyé : jeudi 13 août 2020 16:06 À : Wolfgang Grandegger ; Stéphane Grosjean Cc : Marc Kleine-Budde ; D

Re: [PATCH net] can: peak_usb: add range checking in decode operations

2020-10-16 Thread Marc Kleine-Budde
On 10/16/20 9:43 AM, Stéphane Grosjean wrote: > Thank you for your detailed answer. And so? AFAIK I saw that this patch is > still > not in mainline. What needs to be done for it to be there? Should I bring an > Ack, for example? If you have reviewed the patch, give an Ack or Reviewed-by. regard

Re: [PATCH net] can: peak_usb: add range checking in decode operations

2020-10-14 Thread Oliver Hartkopp
Hi Stephane, On 14.10.20 15:22, Stéphane Grosjean wrote: Hello Dan, Don't know if this patch is still relevant, but: - there is absolutely no reason for the device firmware to provide a channel index greater than or equal to 2, because the IP core of these USB devices handles 2 channels only

RE: [PATCH net] can: peak_usb: add range checking in decode operations

2020-10-14 Thread Stéphane Grosjean
Hello Dan, Don't know if this patch is still relevant, but: - there is absolutely no reason for the device firmware to provide a channel index greater than or equal to 2, because the IP core of these USB devices handles 2 channels only. Anyway, these changes are correct. - considering the verif