Re: [PATCH net] af_packet: fix the tx skb protocol in raw sockets with ETH_P_ALL

2019-10-16 Thread Maciej Żenczykowski
> The Fixes tag is missing. Calling sendmsg on a packet socket bound to > ETH_P_ALL goes back a long way. It is a user, not kernel, bug to do > so. I would argue it's not a bug at all - at least not the way you phrased it. AFAIK it can/could be done correctly via specifying the protocol in the sl

Re: [PATCH net] af_packet: fix the tx skb protocol in raw sockets with ETH_P_ALL

2019-03-18 Thread David Miller
From: Willem de Bruijn Date: Mon, 18 Mar 2019 10:49:56 -0400 > On Mon, Mar 18, 2019 at 1:41 AM Yoshiki Komachi > wrote: >> >> I am using "protocol ip" filters in TC to manipulate TC flower >> classifiers, which are only available with "protocol ip". However, >> I faced an issue that packets sent

Re: [PATCH net] af_packet: fix the tx skb protocol in raw sockets with ETH_P_ALL

2019-03-18 Thread Willem de Bruijn
On Mon, Mar 18, 2019 at 1:41 AM Yoshiki Komachi wrote: > > I am using "protocol ip" filters in TC to manipulate TC flower > classifiers, which are only available with "protocol ip". However, > I faced an issue that packets sent via raw sockets with ETH_P_ALL > did not match the ip filters even if